[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <164730e5.e7cf6.1898b96fb76.Coremail.linma@zju.edu.cn>
Date: Tue, 25 Jul 2023 13:47:55 +0800 (GMT+08:00)
From: "Lin Ma" <linma@....edu.cn>
To: "Hangbin Liu" <liuhangbin@...il.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, razor@...ckwall.org, idosch@...dia.com,
lucien.xin@...il.com, edwin.peer@...adcom.com, jiri@...nulli.us,
md.fahad.iqbal.polash@...el.com, anirudh.venkataramanan@...el.com,
jeffrey.t.kirsher@...el.com, neerav.parikh@...el.com,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] rtnetlink: let rtnl_bridge_setlink checks
IFLA_BRIDGE_MODE length
Hello Hangbin,
>
> If we got attr tIFLA_BRIDGE_FLAGS first, it will break here and not check
> the later IFLA_BRIDGE_MODE.
>
> > +
> > + if (nla_type(attr) == IFLA_BRIDGE_MODE) {
> > + if (nla_len(attr) < sizeof(u16))
> > + return -EINVAL;
> > + }
> > }
> > }
>
> Thanks
> Hangbin
Yeah, you are soooo right, will fix this ASAP
Regards
Lin
Powered by blists - more mailing lists