linux-kernel - Re: [PATCH v4 12/32] sound: usb: Export USB SND APIs for modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fs5cv5y0.wl-tiwai@suse.de>
Date:   Tue, 25 Jul 2023 08:52:23 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Wesley Cheng <quic_wcheng@...cinc.com>, agross@...nel.org,
        andersson@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        catalin.marinas@....com, will@...nel.org, mathias.nyman@...el.com,
        lgirdwood@...il.com, broonie@...nel.org, perex@...ex.cz,
        tiwai@...e.com, srinivas.kandagatla@...aro.org,
        bgoswami@...cinc.com, Thinh.Nguyen@...opsys.com,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-usb@...r.kernel.org, alsa-devel@...a-project.org,
        quic_jackp@...cinc.com, pierre-louis.bossart@...ux.intel.com,
        oneukum@...e.com, albertccwang@...gle.com, o-takashi@...amocchi.jp
Subject: Re: [PATCH v4 12/32] sound: usb: Export USB SND APIs for modules

On Tue, 25 Jul 2023 07:33:57 +0200,
Greg KH wrote:
> 
> On Mon, Jul 24, 2023 at 07:33:56PM -0700, Wesley Cheng wrote:
> > --- a/sound/usb/pcm.c
> > +++ b/sound/usb/pcm.c
> > @@ -87,7 +87,7 @@ static snd_pcm_uframes_t snd_usb_pcm_pointer(struct snd_pcm_substream *substream
> >  /*
> >   * find a matching audio format
> >   */
> > -static const struct audioformat *
> > +const struct audioformat *
> >  find_format(struct list_head *fmt_list_head, snd_pcm_format_t format,
> >  	    unsigned int rate, unsigned int channels, bool strict_match,
> >  	    struct snd_usb_substream *subs)
> > @@ -147,8 +147,9 @@ find_format(struct list_head *fmt_list_head, snd_pcm_format_t format,
> >  	}
> >  	return found;
> >  }
> > +EXPORT_SYMBOL_GPL(find_format);
> 
> This is a horrible symbol name for a global function, same for the other
> ones in this file.  If you really want to export them, please put them
> in the proper "snd_" prefix namespace, or better yet, use a module
> namespace as well to ensure that we know who is using them.

Yes, please add snd_usb_ prefix for all exported symbols from
USB-audio driver code.

Also, make sure that EXPORT_SYMBOL_GPL() is used for those, too.


thanks,

Takashi