linux-kernel - Re: [PATCH] MIPS: prefer 'unsigned int' to bare use of 'unsigned'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZL+LvWjuWWJPXTIG@alpha.franken.de>
Date:   Tue, 25 Jul 2023 10:45:49 +0200
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     xuanzhenggang001@...suo.com
Cc:     linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: prefer 'unsigned int' to bare use of 'unsigned'

On Sun, Jul 09, 2023 at 10:19:50PM +0800, xuanzhenggang001@...suo.com wrote:
> Fix the following warnings reported by checkpatch:
> 
> arch/mips/kernel/linux32.c:128: WARNING: Prefer 'unsigned int' to bare use
> of 'unsigned'
> arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use
> of 'unsigned'
> arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use
> of 'unsigned'
> arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use
> of 'unsigned'
> 
> Signed-off-by: Zhenggang Xuan <xuanzhenggang001@...suo.com>
> ---
>  arch/mips/kernel/linux32.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/mips/kernel/linux32.c b/arch/mips/kernel/linux32.c
> index 6b61be486303..4bd52b38dd00 100644
> --- a/arch/mips/kernel/linux32.c
> +++ b/arch/mips/kernel/linux32.c
> @@ -125,8 +125,8 @@ asmlinkage long sys32_fadvise64_64(int fd, int __pad,
>              flags);
>  }
> 
> -asmlinkage long sys32_fallocate(int fd, int mode, unsigned offset_a2,
> -    unsigned offset_a3, unsigned len_a4, unsigned len_a5)
> +asmlinkage long sys32_fallocate(int fd, int mode, unsigned int offset_a2,
> +    unsigned int offset_a3, unsigned int len_a4, unsigned int len_a5)
>  {
>      return ksys_fallocate(fd, mode, merge_64(offset_a2, offset_a3),
>                    merge_64(len_a4, len_a5));

this is white-space damaged, please resend with that corrected.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]