linux-kernel - Re: [PATCH V4 net-next] net: mana: Configure hwc timeout from hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 25 Jul 2023 15:19:24 +0530
From:   Souradeep Chakrabarti <souradch.linux@...il.com>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Souradeep Chakrabarti <schakrabarti@...ux.microsoft.com>,
        kys@...rosoft.com, haiyangz@...rosoft.com, wei.liu@...nel.org,
        decui@...rosoft.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, longli@...rosoft.com,
        sharmaajay@...rosoft.com, cai.huoqing@...ux.dev,
        ssengar@...ux.microsoft.com, vkuznets@...hat.com,
        tglx@...utronix.de, linux-hyperv@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-rdma@...r.kernel.org, schakrabarti@...rosoft.com
Subject: Re: [PATCH V4 net-next] net: mana: Configure hwc timeout from hardware

On Wed, Jul 19, 2023 at 12:43 PM Leon Romanovsky <leon@...nel.org> wrote:
>
> On Tue, Jul 18, 2023 at 11:00:32AM -0700, Souradeep Chakrabarti wrote:
> > At present hwc timeout value is a fixed value. This patch sets the hwc
> > timeout from the hardware. It now uses a new hardware capability
> > GDMA_DRV_CAP_FLAG_1_HWC_TIMEOUT_RECONFIG to query and set the value
> > in hwc_timeout.
> >
> > Signed-off-by: Souradeep Chakrabarti <schakrabarti@...ux.microsoft.com>
> > ---
> > V3 -> V4:
> > * Changing branch to net-next.
> > * Changed the commit message to 75 chars per line.
> > ---
> >  .../net/ethernet/microsoft/mana/gdma_main.c   | 30 ++++++++++++++++++-
> >  .../net/ethernet/microsoft/mana/hw_channel.c  | 25 +++++++++++++++-
> >  include/net/mana/gdma.h                       | 20 ++++++++++++-
> >  include/net/mana/hw_channel.h                 |  5 ++++
> >  4 files changed, 77 insertions(+), 3 deletions(-)
>
> <...>
>
> >       gc->hwc.driver_data = NULL;
> >       gc->hwc.gdma_context = NULL;
> > @@ -818,6 +839,7 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len,
> >               dest_vrq = hwc->pf_dest_vrq_id;
> >               dest_vrcq = hwc->pf_dest_vrcq_id;
> >       }
> > +     dev_err(hwc->dev, "HWC: timeout %u ms\n", hwc->hwc_timeout);
>
> Why do you print this message every time and with error level?
> Probably you should delete it.
>
In V5 I have changed it to dev_dbg from dev_err.
> Thanks