linux-kernel - RE: [EXT] Re: [PATCH v2 3/3] i2c: imx-lpi2c: add debug message when i2c peripheral clk doesn't work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB7PR04MB5003B6791D90142775B8E145E803A@DB7PR04MB5003.eurprd04.prod.outlook.com>
Date:   Tue, 25 Jul 2023 01:59:32 +0000
From:   Carlos Song <carlos.song@....com>
To:     Fabio Estevam <festevam@...il.com>
CC:     "andi.shyti@...nel.org" <andi.shyti@...nel.org>,
        Aisheng Dong <aisheng.dong@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        Clark Wang <xiaoning.wang@....com>,
        Bough Chen <haibo.chen@....com>,
        dl-linux-imx <linux-imx@....com>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] Re: [PATCH v2 3/3] i2c: imx-lpi2c: add debug message when
 i2c peripheral clk doesn't work

Thanks! I will adjust it and send V3 patch.

> -----Original Message-----
> From: Fabio Estevam <festevam@...il.com>
> Sent: Monday, July 24, 2023 8:38 PM
> To: Carlos Song <carlos.song@....com>
> Cc: andi.shyti@...nel.org; Aisheng Dong <aisheng.dong@....com>;
> shawnguo@...nel.org; s.hauer@...gutronix.de; kernel@...gutronix.de;
> Clark Wang <xiaoning.wang@....com>; Bough Chen <haibo.chen@....com>;
> dl-linux-imx <linux-imx@....com>; linux-i2c@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> Subject: [EXT] Re: [PATCH v2 3/3] i2c: imx-lpi2c: add debug message when i2c
> peripheral clk doesn't work
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report this
> email' button
> 
> 
> On Mon, Jul 24, 2023 at 7:52 AM <carlos.song@....com> wrote:
> >
> > From: Gao Pan <pandy.gao@....com>
> >
> > Output error log when i2c peripheral clk rate is 0, then directly
> > return -EINVAL.
> >
> > Fixes: a55fa9d0e42e ("i2c: imx-lpi2c: add low power i2c bus driver")
> > Signed-off-by: Gao Pan <pandy.gao@....com>
> > Signed-off-by: Carlos Song <carlos.song@....com>
> > ---
> >  drivers/i2c/busses/i2c-imx-lpi2c.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c
> > b/drivers/i2c/busses/i2c-imx-lpi2c.c
> > index e93ff3b5373c..12b4f2a89343 100644
> > --- a/drivers/i2c/busses/i2c-imx-lpi2c.c
> > +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
> > @@ -214,6 +214,11 @@ static int lpi2c_imx_config(struct lpi2c_imx_struct
> *lpi2c_imx)
> >         lpi2c_imx_set_mode(lpi2c_imx);
> >
> >         clk_rate = clk_get_rate(lpi2c_imx->clks[0].clk);
> > +       if (!clk_rate) {
> > +               dev_err(&lpi2c_imx->adapter.dev, "clk_per rate is
> > + 0\n");
> 
> The subject says 'debug message', but this is an error message.
> 
> Please adjust the Subject.