lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230725095925.25121-1-ante.knezic@helmholz.de>
Date:   Tue, 25 Jul 2023 11:59:25 +0200
From:   Ante Knezic <ante.knezic@...mholz.de>
To:     <pabeni@...hat.com>
CC:     <andrew@...n.ch>, <ante.knezic@...mholz.de>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <f.fainelli@...il.com>, <kuba@...nel.org>,
        <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        <olteanv@...il.com>
Subject: Re: [PATCH net-next v3] net: dsa: mv88e6xxx: Add erratum 3.14 for 88E6390X and 88E6190X

On Tue, 25 Jul 2023 10:56:25 +0200 Paolo Abeni wrote
> It looks like you are ignoring the errors reported by
> mv88e6390_erratum_3_14(). Should the above be:
> 
> 		return mv88e6390_erratum_3_14(mpcs);
> 
> instead?
> 

I guess you are right. Would it make sense to do the evaluation for the 
	mv88e639x_sgmii_pcs_control_pwr(mpcs, true);
above as well?

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ