linux-kernel - Re: [PATCH] ALSA: compress: add opus codec define

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOM6g_Db8qwbDmbWSSLKqUHsSMLUYxFtpqKi1cWsXsXTE9B+vA@mail.gmail.com>
Date:   Tue, 25 Jul 2023 18:14:56 +0800
From:   Robert Lee <lerobert@...gle.com>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     vkoul@...nel.org, perex@...ex.cz, tiwai@...e.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: compress: add opus codec define

Thanks for reply so quickly.
And yes, there are other changes but it is inside our offload pcm
driver to handle it.
Currently we only use it to decode, and we don't need additional option for it.

Thanks,
Robert.

Takashi Iwai <tiwai@...e.de> 於 2023年7月25日 週二 下午6:05寫道：
>
> On Tue, 25 Jul 2023 11:30:05 +0200,
> Robert Lee wrote:
> >
> > Add to support decode Opus codec in Ogg container.
> >
> > Signed-off-by: Robert Lee <lerobert@...gle.com>
>
> The change makes sense only when it's really used.  So usually it's
> better to put into a series that actually implements its usage.
>
>
> thanks,
>
> Takashi
>
> > ---
> >  include/uapi/sound/compress_params.h | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/uapi/sound/compress_params.h b/include/uapi/sound/compress_params.h
> > index ddc77322d571..bac5797bcb02 100644
> > --- a/include/uapi/sound/compress_params.h
> > +++ b/include/uapi/sound/compress_params.h
> > @@ -43,7 +43,8 @@
> >  #define SND_AUDIOCODEC_BESPOKE               ((__u32) 0x0000000E)
> >  #define SND_AUDIOCODEC_ALAC                  ((__u32) 0x0000000F)
> >  #define SND_AUDIOCODEC_APE                   ((__u32) 0x00000010)
> > -#define SND_AUDIOCODEC_MAX                   SND_AUDIOCODEC_APE
> > +#define SND_AUDIOCODEC_OPUS                  ((__u32) 0x00000011)
> > +#define SND_AUDIOCODEC_MAX                   SND_AUDIOCODEC_OPUS
> >
> >  /*
> >   * Profile and modes are listed with bit masks. This allows for a
> > --
> > 2.41.0.487.g6d72f3e995-goog
> >