linux-kernel - [PATCH v2] gpio: lp3943: remove unneeded platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230725102532.3989-1-aboutphysycs@gmail.com>
Date:   Tue, 25 Jul 2023 13:25:32 +0300
From:   Andrei Coardos <aboutphysycs@...il.com>
To:     linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org
Cc:     andy@...nel.org, brgl@...ev.pl, linus.walleij@...aro.org,
        Andrei Coardos <aboutphysycs@...il.com>,
        Alexandru Ardelean <alex@...uggie.ro>
Subject: [PATCH v2] gpio: lp3943: remove unneeded platform_set_drvdata() call

This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call, to access the private data of the driver.
Also, the private data is defined in this driver, so there is no risk of
it being accessed outside of this driver file.

Reviewed-by: Alexandru Ardelean <alex@...uggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@...il.com>
---

Changelog V1->V2: 
* https://lore.kernel.org/linux-gpio/CAHp75VdU1c1vUoRpbekPXoLg2DDcbSThwUmkdHRT2FaZ9kagRA@mail.gmail.com/T/#t
* https://lore.kernel.org/linux-gpio/ZLpdOYxo2U+uO%2FH3@smile.fi.intel.com/T/#t
* fixed subject line: adjusted colons where needed

 drivers/gpio/gpio-lp3943.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpio/gpio-lp3943.c b/drivers/gpio/gpio-lp3943.c
index 79edd5db49d2..8e58242f5123 100644
--- a/drivers/gpio/gpio-lp3943.c
+++ b/drivers/gpio/gpio-lp3943.c
@@ -199,8 +199,6 @@ static int lp3943_gpio_probe(struct platform_device *pdev)
 	lp3943_gpio->chip = lp3943_gpio_chip;
 	lp3943_gpio->chip.parent = &pdev->dev;
 
-	platform_set_drvdata(pdev, lp3943_gpio);
-
 	return devm_gpiochip_add_data(&pdev->dev, &lp3943_gpio->chip,
 				      lp3943_gpio);
 }
-- 
2.34.1