linux-kernel - Re: [PATCH] x86: Fix amd_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 25 Jul 2023 14:15:16 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Borislav Petkov" <bp@...en8.de>, "Arnd Bergmann" <arnd@...nel.org>
Cc:     "Thomas Gleixner" <tglx@...utronix.de>,
        "Ingo Molnar" <mingo@...hat.com>,
        "Dave Hansen" <dave.hansen@...ux.intel.com>, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>,
        "Kees Cook" <keescook@...omium.org>,
        "Kim Phillips" <kim.phillips@....com>,
        "Alexey Kardashevskiy" <aik@....com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: Fix amd_check_microcode() declaration

On Tue, Jul 25, 2023, at 11:20, Borislav Petkov wrote:
> On Tue, Jul 25, 2023 at 10:26:13AM +0200, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@...db.de>
>> 
>> The newly added amd_check_microcode() function has two conflicting definitions
>> if CONFIG_CPU_SUP_AMD is enabled and CONFIG_MICROCODE_AMD is disabled. Since
>> the header with the stub definition is not included in cpu/amd.c, this only
>> causes a -Wmissing-prototype warning with W=1
>
> Can we please promote -Wmissing-prototype to default or is it too noisy
> yet?

I'm working on it, currently missing just 15 patches (down from 70 in 6.3)
before all randconfigs on x86 and arm are clean.

>> diff --git a/arch/x86/include/asm/microcode_amd.h b/arch/x86/include/asm/microcode_amd.h
>> index 9675c621c1ca4..6a860d40b0411 100644
>> --- a/arch/x86/include/asm/microcode_amd.h
>> +++ b/arch/x86/include/asm/microcode_amd.h

>> +#ifdef CONFIG_CPU_SUP_AMD
>> +extern void amd_check_microcode(void);
>> +#else
>>  static inline void amd_check_microcode(void) {}
>>  #endif
>> +
>>  #endif /* _ASM_X86_MICROCODE_AMD_H */
>
> Considering how cpu/amd.c provides the function implementation, that
> header gunk should not be in microcode_amd.h but in ...asm/processor.h,
> I'd say.

Ok, I'll send a v2 with that changed.

     Arnd