linux-kernel - Re: [PATCH V2 1/4] ASoC: codecs: Add code for bin parsing compatible with aw88261

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6e8c950-9d1f-099a-b48a-2b838ed04ac7@linaro.org>
Date:   Tue, 25 Jul 2023 14:24:32 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     wangweidong.a@...nic.com, lgirdwood@...il.com, broonie@...nel.org,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, perex@...ex.cz, tiwai@...e.com,
        rf@...nsource.cirrus.com, shumingf@...ltek.com,
        povik+lin@...ebit.org, 13916275206@....com,
        herve.codina@...tlin.com, ryans.lee@...log.com,
        ckeepax@...nsource.cirrus.com,
        ajye_huang@...pal.corp-partner.google.com,
        sebastian.reichel@...labora.com, yijiangtao@...nic.com,
        trix@...hat.com, colin.i.king@...il.com, liweilei@...nic.com,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     zhangjianming@...nic.com
Subject: Re: [PATCH V2 1/4] ASoC: codecs: Add code for bin parsing compatible
 with aw88261

On 25/07/2023 13:56, wangweidong.a@...nic.com wrote:
> From: Weidong Wang <wangweidong.a@...nic.com>
> 
> Add the awinic,aw88261 property to the awinic,aw88395.yaml file
> Add aw88395_lib.c file compatible with aw88261 bin file parsing code
> 
> Signed-off-by: Weidong Wang <wangweidong.a@...nic.com>
> ---
>  .../bindings/sound/awinic,aw88395.yaml        |   4 +-
>  sound/soc/codecs/aw88395/aw88395_lib.c        | 194 ++++++++++++++++--
>  sound/soc/codecs/aw88395/aw88395_reg.h        |   1 +
>  3 files changed, 181 insertions(+), 18 deletions(-)

Bindings are always separate patches.

Please run scripts/checkpatch.pl and fix reported warnings. Some
warnings can be ignored, but the code here looks like it needs a fix.
Feel free to get in touch if the warning is not clear.

Best regards,
Krzysztof