linux-kernel - Re: [PATCH] gpio: msc313: remove unnecessary call to platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZL/L1tiKjLDP5bet@smile.fi.intel.com>
Date:   Tue, 25 Jul 2023 16:19:18 +0300
From:   Andy Shevchenko <andy@...nel.org>
To:     Andrei Coardos <aboutphysycs@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, brgl@...ev.pl,
        linus.walleij@...aro.org, romain.perier@...il.com,
        daniel@...ngy.jp, Alexandru Ardelean <alex@...uggie.ro>
Subject: Re: [PATCH] gpio: msc313: remove unnecessary call to
 platform_set_drvdata()

On Fri, Jul 21, 2023 at 07:14:31PM +0300, Andy Shevchenko wrote:
> On Fri, Jul 21, 2023 at 04:11:57PM +0300, Andrei Coardos wrote:
> > This function call was found to be unnecessary as there is no equivalent
> > platform_get_drvdata() call to access the private data of the driver.

Not true.

> > Also, the private data is defined in this driver, so there is no risk of
> > it being accessed outside of this driver file.
> 
> Reviewed-by: Andy Shevchenko <andy@...nel.org>

I have to withdraw this, the patch is wrong.
NAK.

Sorry for the confusion (I have looked for the wrong pattern).

-- 
With Best Regards,
Andy Shevchenko