[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZMEwuMLQlwABZeRo@smile.fi.intel.com>
Date: Wed, 26 Jul 2023 17:42:00 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
Ruihong Luo <colorsu1922@...il.com>,
Jiri Slaby <jirislaby@...nel.org>,
LKML <linux-kernel@...r.kernel.org>,
linux-serial <linux-serial@...r.kernel.org>,
stable@...r.kernel.org, luoruihong@...omi.com,
weipengliang@...omi.com, wengjinfei@...omi.com
Subject: Re: [PATCH v4] serial: 8250_dw: Preserve original value of DLF
register
On Tue, Jul 25, 2023 at 08:31:17PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Jul 14, 2023 at 03:31:11PM +0300, Andy Shevchenko wrote:
> > On Fri, Jul 14, 2023 at 03:07:42PM +0300, Ilpo Järvinen wrote:
> > > On Thu, 13 Jul 2023, Ruihong Luo wrote:
> > >
> > > > Preserve the original value of the Divisor Latch Fraction (DLF) register.
> > > > When the DLF register is modified without preservation, it can disrupt
> > > > the baudrate settings established by firmware or bootloader, leading to
> > > > data corruption and the generation of unreadable or distorted characters.
> > > >
> > > > Fixes: 701c5e73b296 ("serial: 8250_dw: add fractional divisor support")
> >
> > > You forgot to add:
> > >
> > > Cc: stable@...r.kernel.org
> >
> > It's there. Just not in the commit message. It's fine.
>
> No it isn't, that's not how to have a patch added to the stable tree, as
> my form letter says:
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree. Please read:
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.
>
> </formletter>
>
> I'll go fix it up by hand...
Good to know, thank you for the clarification!
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists