linux-kernel - Re: [PATCH -next] i2c: s3c2410: Remove redundant dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230726144619.qo3ttjjmjvliwz23@intel.intel>
Date:   Wed, 26 Jul 2023 16:46:19 +0200
From:   Andi Shyti <andi.shyti@...nel.org>
To:     Ruan Jinjie <ruanjinjie@...wei.com>
Cc:     krzysztof.kozlowski@...aro.org, alim.akhtar@...sung.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org, linux-i2c@...r.kernel.org
Subject: Re: [PATCH -next] i2c: s3c2410: Remove redundant dev_err()

Hi Ruan,

On Wed, Jul 26, 2023 at 05:42:26PM +0000, Ruan Jinjie wrote:
> There is no need to call the dev_err() function directly to print a custom
> message when handling an error from platform_get_irq() function as
> it is going to display an appropriate error message in case of a failure.
> 
> Signed-off-by: Ruan Jinjie <ruanjinjie@...wei.com>

Correct!

Reviewed-by: Andi Shyti <andi.shyti@...nel.org> 

Andi