[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7e4f6c51-43f4-c039-07bc-6724748a1d3e@acm.org>
Date: Wed, 26 Jul 2023 07:54:24 -0700
From: Bart Van Assche <bvanassche@....org>
To: Daniel Wagner <dwagner@...e.de>, linux-nvme@...ts.infradead.org
Cc: linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
Chaitanya Kulkarni <kch@...dia.com>,
Shin'ichiro Kawasaki <shinichiro.kawasaki@....com>,
Max Gurtovoy <mgurtovoy@...dia.com>,
Hannes Reinecke <hare@...e.de>,
Sagi Grimberg <sagi@...mberg.me>,
James Smart <jsmart2021@...il.com>
Subject: Re: [PATCH blktests v1 01/11] nvme/{003,004,005,013,046,049}: Group
all variables declarations
On 7/26/23 05:46, Daniel Wagner wrote:
> Group all variable declarations together at the beginning of the
> function.
An explanation of why this change has been proposed is missing from the
patch description.
I think the current style, with variable declarations occurring just
before the first use of a variable, is on purpose. I like that style.
Bart.
Powered by blists - more mailing lists