linux-kernel - Re: [PATCH v2] spi: Use dev_err_probe instead of dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 26 Jul 2023 08:02:10 -0700
From:   Florian Fainelli <florian.fainelli@...adcom.com>
To:     Wang Ming <machel@...o.com>, Mark Brown <broonie@...nel.org>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>, linux-spi@...r.kernel.org,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:     opensource.kernel@...o.com
Subject: Re: [PATCH v2] spi: Use dev_err_probe instead of dev_err



On 7/26/2023 3:54 AM, Wang Ming wrote:
> It is possible that dma_request_chan will return EPROBE_DEFER,
> which means that dev is not ready yet. In this case,
> dev_err(dev), there will be no output. This patch fixes the bug.
> 
> Signed-off-by: Wang Ming <machel@...o.com>

This looks reasonable, though could you use the same prefix that was 
used for previous changes:

spi: bcm2835: Use dev_err_probe instead of dev_err

with that done, please add a:

Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>
-- 
Florian

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4221 bytes)