Message-ID: <ZMCWw09Huez5ikef@aschofie-mobl2>
Date:   Tue, 25 Jul 2023 20:45:07 -0700
From:   Alison Schofield <alison.schofield@...el.com>
To:     Raghu Halharvi <raghuhack78@...il.com>
Cc:     linux-cxl@...r.kernel.org, ira.weiny@...el.com,
        bwidawsk@...nel.org, dan.j.williams@...el.com,
        vishal.l.verma@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND v6 0/2] Fixing check patch styling issues

On Tue, Jul 25, 2023 at 07:43:39PM +0000, Raghu Halharvi wrote:
> v6 changes:
> - The v5 was approved was not committed, submitting both patches(v6)
>   addressing styling issues in cxl/mbox.c and cxl/region.c after
>   rebasing with latest source. The changes remain same except the
>   function in which redundant dev_err() was present has been renamed to
>   cxl_memdev_state_create. (Alison/Ira)

Hi Raghu,

This posting is a new cover letter alone, and it has the same exact
Subject line as the previous cover letter which had patches attached.
As you might imagin, that is confusing to humans and may be confusing
to automated tools.

Please try this:

Next version is v7, not a resend

v7 changes:
- Append the actual patches that were omitted in previous send
- Update the v6 changelog
- Reorder and remove blank line in Patch Tags

v6 changes:
- Rebase 
- Do the redundant dev_err() cleanup in cxl_memdev_state_create()


By Reorder the patch tags, I mean:

Replace this:
Reviewed-by: Vishal Verma <vishal.l.verma@...el.com>
Reviewed-by: Dave Jiang <dave.jiang@...el.com>
Reviewed-by: Ira Weiny <ira.weiny@...el.com>

Signed-off-by: Raghu Halharvi <raghuhack78@...il.com>

With this:
Signed-off-by: Raghu Halharvi <raghuhack78@...il.com>
Reviewed-by: Vishal Verma <vishal.l.verma@...el.com>
Reviewed-by: Dave Jiang <dave.jiang@...el.com>
Reviewed-by: Ira Weiny <ira.weiny@...el.com>

There should be no space among the tags, and they get listed in
the order of arrival. ie. You gave your Signed-off-by first,
and then the Reviewed-by tags follow. The maintainer who applies
your patches, will add their Signed-off-by Tag last upon merging.

(If you'd like to try something new and useful, look up git format-patch
--base option. We often use that in a patchset to tell reviewers and
those who will apply the set, the base commit)

Thanks for keeping at it Raghu!

Alison

> 
> v5 changes:
> - Updated the missing reviewed tag in "cxl/mbox: Remove redundant
>   dev_err() after failed mem alloc" patch (Dave Jiang)
> 
> v4 changes:
> - Updated the respective patches with reviewers tags for respective
>   patches(Dave Jiang)
> 
> v3 changes:
> - Update the cover letter and commit message with full author
>   name(Fabio/Alison)
> - Correct the "typo error" in commit message(Fabio)
> 
> v2 changes:
> Thanks Alison, Ira for your comments, modified the v1 patches as
> suggested.
> Dropped the patch containing tab changes in port.c
> 
> v1 cover letter:
> The following patches are cleanup or fixing the styling issues found
> using checkpatch
> 
> In cxl/core/mbox.c, in case of null check failure, returning errno or
> -ENOMEM in this case is good enough, removing the redundant dev_err
> message.
> 
> In cxl/core/region.c, the else is not required after the return
> statement, cleaned it up.
> 
> Verified the build and sanity by booting the guest VM using the freshly
> built components.
> 
> Raghu Halharvi (2):
>   cxl/mbox: Remove redundant dev_err() after failed mem alloc
>   cxl/region: Remove else after return statement
> 
>  drivers/cxl/core/mbox.c   | 4 +---
>  drivers/cxl/core/region.c | 8 ++++----
>  2 files changed, 5 insertions(+), 7 deletions(-)
> 
> -- 
> 2.39.2
> 

Powered by blists - more mailing lists