linux-kernel - Re: [PATCH] NFSv4.2: fix error handling in nfs42_proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4CA714BC-E458-4F90-B6D4-C61B5A8D61CF@redhat.com>
Date:   Wed, 26 Jul 2023 11:04:24 -0400
From:   Benjamin Coddington <bcodding@...hat.com>
To:     Fedor Pchelkin <pchelkin@...ras.ru>
Cc:     Trond Myklebust <trond.myklebust@...merspace.com>,
        Anna Schumaker <anna@...nel.org>,
        Frank van der Linden <fllinden@...zon.com>,
        linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org,
        Alexey Khoroshilov <khoroshilov@...ras.ru>,
        lvc-project@...uxtesting.org
Subject: Re: [PATCH] NFSv4.2: fix error handling in nfs42_proc_getxattr

On 25 Jul 2023, at 7:58, Fedor Pchelkin wrote:

> There is a slight issue with error handling code inside
> nfs42_proc_getxattr(). If page allocating loop fails then we free the
> failing page array element which is NULL but __free_page() can't deal with
> NULL args.
>
> Found by Linux Verification Center (linuxtesting.org).
>
> Fixes: a1f26739ccdc ("NFSv4.2: improve page handling for GETXATTR")
> Signed-off-by: Fedor Pchelkin <pchelkin@...ras.ru>

Looks right to me,

Reviewed-by: Benjamin Coddington <bcodding@...hat.com>

Ben