linux-kernel - Re: [PATCH net-next] Bluetooth: Remove unused declaration amp_read_loc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2cf9a03e-6d81-64cd-3cc2-0b989e5d5824@molgen.mpg.de>
Date:   Wed, 26 Jul 2023 17:11:09 +0200
From:   Paul Menzel <pmenzel@...gen.mpg.de>
To:     yuehaibing@...wei.com
Cc:     marcel@...tmann.org, johan.hedberg@...il.com, luiz.dentz@...il.com,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] Bluetooth: Remove unused declaration
 amp_read_loc_info()

Dear YueHaibing,


Thank you very much for your patch.

Am 26.07.23 um 16:28 schrieb YueHaibing:
> This is never used, so remove it.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Should your name be spelled with a space: Yue Haibing?

     $ git config --global user.name "Yue Haibing"
     $ git commit --amend --author="Yue Haibing <yuehaibing@...wei.com>"

> ---
>   net/bluetooth/amp.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/net/bluetooth/amp.h b/net/bluetooth/amp.h
> index 832764dfbfb3..97c87abd129f 100644
> --- a/net/bluetooth/amp.h
> +++ b/net/bluetooth/amp.h
> @@ -28,7 +28,6 @@ struct hci_conn *phylink_add(struct hci_dev *hdev, struct amp_mgr *mgr,
>   
>   int phylink_gen_key(struct hci_conn *hcon, u8 *data, u8 *len, u8 *type);
>   
> -void amp_read_loc_info(struct hci_dev *hdev, struct amp_mgr *mgr);

Was it never implemented, or just forgotten to be removed?

>   void amp_read_loc_assoc_frag(struct hci_dev *hdev, u8 phy_handle);
>   void amp_read_loc_assoc(struct hci_dev *hdev, struct amp_mgr *mgr);
>   void amp_read_loc_assoc_final_data(struct hci_dev *hdev,


Kind regards,

Paul