linux-kernel - Re: [PATCH] NFSv4: fix out path in __nfs4_get_acl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BC2D2754-5E16-408E-AC74-E1DD34821620@redhat.com>
Date:   Wed, 26 Jul 2023 11:09:26 -0400
From:   Benjamin Coddington <bcodding@...hat.com>
To:     Fedor Pchelkin <pchelkin@...ras.ru>
Cc:     Trond Myklebust <trond.myklebust@...merspace.com>,
        Anna Schumaker <anna@...nel.org>,
        Olga Kornievskaia <kolga@...app.com>,
        linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org,
        Alexey Khoroshilov <khoroshilov@...ras.ru>,
        lvc-project@...uxtesting.org
Subject: Re: [PATCH] NFSv4: fix out path in __nfs4_get_acl_uncached

On 25 Jul 2023, at 7:59, Fedor Pchelkin wrote:

> Another highly rare error case when a page allocating loop (inside
> __nfs4_get_acl_uncached, this time) is not properly unwound on error.
> Since pages array is allocated being uninitialized, need to free only
> lower array indices. NULL checks were useful before commit 62a1573fcf84
> ("NFSv4 fix acl retrieval over krb5i/krb5p mounts") when the array had
> been initialized to zero on stack.
>
> Found by Linux Verification Center (linuxtesting.org).
>
> Fixes: 62a1573fcf84 ("NFSv4 fix acl retrieval over krb5i/krb5p mounts")
> Signed-off-by: Fedor Pchelkin <pchelkin@...ras.ru>

Nice one.

Reviewed-by: Benjamin Coddington <bcodding@...hat.com>