linux-kernel - Re: [PATCH] i2c: tiny-usb: check usb base class before assuming the interface on device is for this driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230726160843.sbutc7g7nrn5g7rh@intel.intel>
Date:   Wed, 26 Jul 2023 18:08:43 +0200
From:   Andi Shyti <andi.shyti@...nel.org>
To:     Harry Geyer <harry.geyer@...tank.co.uk>
Cc:     Till Harbaum <till@...baum.org>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: tiny-usb: check usb base class before assuming the
 interface on device is for this driver

Hi Harry,

it's OK, just few little adjustments...

On Wed, Jul 19, 2023 at 12:38:38PM +0100, Harry Geyer wrote:
> Patch allows usb devices with multiple interfaces to use this driver without
> this driver assuming all interfaces are i2c-tiny-usb.
> 
> Signed-off-by: Harry Geyer <harry.geyer@...tank.co.uk>

Please add:

Fixes: e8c76eed2ecd ("i2c: New i2c-tiny-usb bus driver")
Cc: Till Harbaum <till@...baum.org>
Cc: <stable@...r.kernel.org> # v2.6.22+

> ---
>  drivers/i2c/busses/i2c-tiny-usb.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/i2c/busses/i2c-tiny-usb.c b/drivers/i2c/busses/i2c-tiny-usb.c
> index d1fa9ff5aeab..fc194c65e50e 100644
> --- a/drivers/i2c/busses/i2c-tiny-usb.c
> +++ b/drivers/i2c/busses/i2c-tiny-usb.c
> @@ -222,6 +222,11 @@ static int i2c_tiny_usb_probe(struct usb_interface *interface,
>  	int retval = -ENOMEM;
>  	u16 version;
>  
> +	if (interface->intf_assoc &&
> +		interface->intf_assoc->bFunctionClass != USB_CLASS_VENDOR_SPEC) {

please fix the indentation here ('interface' and 'interface'
should go on the same line)

> +		return -ENODEV;
> +	}

please drop the brackets.

Andi

> +
>  	dev_dbg(&interface->dev, "probing usb device\n");
>  
>  	/* allocate memory for our device state and initialize it */
> -- 
> 2.34.1
>