[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZMFVZJa647SNwrJX@gerhold.net>
Date: Wed, 26 Jul 2023 19:18:28 +0200
From: Stephan Gerhold <stephan@...hold.net>
To: Konrad Dybcio <konrad.dybcio@...aro.org>
Cc: Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Georgi Djakov <djakov@...nel.org>,
Marijn Suijten <marijn.suijten@...ainline.org>,
linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] interconnect: qcom: qcm2290: Set AB coefficients
On Wed, Jul 26, 2023 at 06:25:44PM +0200, Konrad Dybcio wrote:
> Some buses need additional manual adjustments atop the usual
> calculations. Fill in the missing coefficients.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
What about the funny util-fact/vrail-comp on the mas-apps-proc node
downstream?
Thanks,
Stephan
> ---
> drivers/interconnect/qcom/qcm2290.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/interconnect/qcom/qcm2290.c b/drivers/interconnect/qcom/qcm2290.c
> index 3c3b24264a5b..457e5713ae43 100644
> --- a/drivers/interconnect/qcom/qcm2290.c
> +++ b/drivers/interconnect/qcom/qcm2290.c
> @@ -1198,6 +1198,7 @@ static const struct qcom_icc_desc qcm2290_bimc = {
> .regmap_cfg = &qcm2290_bimc_regmap_config,
> /* M_REG_BASE() in vendor msm_bus_bimc_adhoc driver */
> .qos_offset = 0x8000,
> + .ab_percent = 153,
> };
>
> static struct qcom_icc_node * const qcm2290_cnoc_nodes[] = {
> @@ -1324,6 +1325,7 @@ static const struct qcom_icc_desc qcm2290_mmnrt_virt = {
> .bus_clk_desc = &mmaxi_0_clk,
> .regmap_cfg = &qcm2290_snoc_regmap_config,
> .qos_offset = 0x15000,
> + .ab_percent = 142,
> };
>
> static struct qcom_icc_node * const qcm2290_mmrt_virt_nodes[] = {
> @@ -1339,6 +1341,7 @@ static const struct qcom_icc_desc qcm2290_mmrt_virt = {
> .bus_clk_desc = &mmaxi_1_clk,
> .regmap_cfg = &qcm2290_snoc_regmap_config,
> .qos_offset = 0x15000,
> + .ab_percent = 139,
> };
>
> static const struct of_device_id qcm2290_noc_of_match[] = {
>
> --
> 2.41.0
>
Powered by blists - more mailing lists