[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0aa471ce-da83-172d-d870-1ec7a562baf7@linaro.org>
Date: Wed, 26 Jul 2023 19:21:14 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: yuji2.ishikawa@...hiba.co.jp, hverkuil@...all.nl,
sakari.ailus@....fi, laurent.pinchart@...asonboard.com,
mchehab@...nel.org, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
nobuhiro1.iwamatsu@...hiba.co.jp, broonie@...nel.org
Cc: linux-media@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 1/5] dt-bindings: media: platform: visconti: Add
Toshiba Visconti Video Input Interface
On 25/07/2023 08:08, yuji2.ishikawa@...hiba.co.jp wrote:
>> unevaluatedProperties: false
>
> In the previous discussion with Laurent, I believe additionalProperties was preferred in terms of handling properties not explicitly mentioned.
>
> https://lore.kernel.org/all/Y82NtJCtr+CZgS9k@pendragon.ideasonboard.com/
OK.
>
> Do you have concern about defaulting properties in video-interface.yaml to forbidden?
> If defaulting to optional (like most of other bindings) is better, I'll use unevaluatedProperties.
>
...
> there's no need to specify clock-lane with device tree.
>
> I'll drop "clock-lanes".
>
>>> +
>>> + bus-type: true
>>> + clock-noncontinuous: true
>>> + link-frequencies: true
>>> + remote-endpoint: true
>>
>> Drop all of these "xxx: true", should not be needed after converting to
>> unevaluatedProperties: false
>>
>
> I'll drop "xxx: true" if unevaluatedProperties is chosen instead of additionalProperties.
Since we keep unevaluated, this should stay.
Best regards,
Krzysztof
Powered by blists - more mailing lists