linux-kernel - Re: [PATCH 0/2] vdpa: Enable strict validation for netlink ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230726152719-mutt-send-email-mst@kernel.org>
Date:   Wed, 26 Jul 2023 15:28:04 -0400
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     Dragos Tatulea <dtatulea@...dia.com>
Cc:     Parav Pandit <parav@...dia.com>,
        "linma@....edu.cn" <linma@....edu.cn>,
        "jasowang@...hat.com" <jasowang@...hat.com>,
        "virtualization@...ts.linux-foundation.org" 
        <virtualization@...ts.linux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "xuanzhuo@...ux.alibaba.com" <xuanzhuo@...ux.alibaba.com>
Subject: Re: [PATCH 0/2] vdpa: Enable strict validation for netlink ops

On Wed, Jul 26, 2023 at 07:23:50PM +0000, Dragos Tatulea wrote:
> On Wed, 2023-07-26 at 20:56 +0200, Dragos Tatulea wrote:
> > On Wed, 2023-07-26 at 14:36 -0400, Michael S. Tsirkin wrote:
> > > On Wed, Jul 26, 2023 at 09:30:48PM +0300, Dragos Tatulea wrote:
> > > > The original patch from Lin Ma enables the vdpa driver to use validation
> > > > netlink ops.
> > > > 
> > > > The second patch simply disables the validation skip which is no longer
> > > > neccesary. Patchset started of from this discussion [0].
> > > > 
> > > > [0]
> > > > https://lore.kernel.org/virtualization/20230726074710-mutt-send-email-mst@kernel.org/T/#t
> > > 
> > > Cc stable with at least 1/2 ?
> > > 
> > Sent a v2 with stable in cc. But looks like 1/2 breaks the "fix one thing
> > only"
> > rule due to the many Fixes tags I guess...

I think it's ok.

> Or my lack of understanding: I only now realize that "Cc: stable" is a tag in
> the patch. My bad. Will re-send.

you also need v2 on subject of each patch.

> > > > Dragos Tatulea (1):
> > > >   vdpa: Enable strict validation for netlinks ops
> > > > 
> > > > Lin Ma (1):
> > > >   vdpa: Complement vdpa_nl_policy for nlattr length check
> > > > 
> > > >  drivers/vdpa/vdpa.c | 9 +++------
> > > >  1 file changed, 3 insertions(+), 6 deletions(-)
> > > > 
> > > > -- 
> > > > 2.41.0
> > > 
> > 
>