[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20230726123642.ab3f2c8382dfdb4fb62ae3e5@linux-foundation.org>
Date: Wed, 26 Jul 2023 12:36:42 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Zhu Wang <wangzhu9@...wei.com>
Cc: <mporter@...nel.crashing.org>, <alex.bou9@...il.com>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] rapidio: fix -Wunused-const-variable= warning
On Wed, 26 Jul 2023 18:17:14 +0800 Zhu Wang <wangzhu9@...wei.com> wrote:
> When building with W=1, the following warning occurs.
>
> drivers/rapidio/rio_cm.c: In function ‘rio_txcq_handler’:
> drivers/rapidio/rio_cm.c:673:7: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]
> int rc;
>
> Since the variable "rc" is not used in function 'rio_txcq_handler',
> so we removed it to remove the warning.
>
> ...
>
> --- a/drivers/rapidio/rio_cm.c
> +++ b/drivers/rapidio/rio_cm.c
> @@ -670,13 +670,12 @@ static void rio_txcq_handler(struct cm_dev *cm, int slot)
> */
> if (!list_empty(&cm->tx_reqs) && (cm->tx_cnt < RIOCM_TX_RING_SIZE)) {
> struct tx_req *req, *_req;
> - int rc;
>
> list_for_each_entry_safe(req, _req, &cm->tx_reqs, node) {
> list_del(&req->node);
> cm->tx_buf[cm->tx_slot] = req->buffer;
> - rc = rio_add_outb_message(cm->mport, req->rdev, cmbox,
> - req->buffer, req->len);
> + rio_add_outb_message(cm->mport, req->rdev, cmbox,
> + req->buffer, req->len);
> kfree(req->buffer);
> kfree(req);
rio_add_outb_message() can fail. It would be better to appropriately
handle these failures, rather than simply ignoring them.
Powered by blists - more mailing lists