linux-kernel - Re: [PATCH] [v2] ata: pata_ns87415: mark ns87560_tf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 27 Jul 2023 08:45:19 +0900
From:   Damien Le Moal <dlemoal@...nel.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>, Sergey Shtylyov <s.shtylyov@....ru>,
        Jon Hunter <jonathanh@...dia.com>,
        Bart Van Assche <bvanassche@....org>,
        linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] ata: pata_ns87415: mark ns87560_tf_read static

On 7/27/23 05:33, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The global function triggers a warning because of the missing prototype
> 
> drivers/ata/pata_ns87415.c:263:6: warning: no previous prototype for 'ns87560_tf_read' [-Wmissing-prototypes]
>   263 | void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
> 
> There are no other references to this, so just make it static.
> 
> Fixes: c4b5b7b6c4423 ("pata_ns87415: Initial cut at 87415/87560 IDE support")
> Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied to for-6.5-fixes. Thanks !


-- 
Damien Le Moal
Western Digital Research