linux-kernel - Re: [PATCH v2 6/6] drm/mediatek: mtk_dpi: Compress struct of_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4907bc5e42d3fffa6cb01c25ab3de5a83d82146c.camel@mediatek.com>
Date:   Wed, 26 Jul 2023 06:02:02 +0000
From:   CK Hu (胡俊光) <ck.hu@...iatek.com>
To:     "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        "chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>
CC:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "fshao@...omium.org" <fshao@...omium.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "kernel@...labora.com" <kernel@...labora.com>
Subject: Re: [PATCH v2 6/6] drm/mediatek: mtk_dpi: Compress struct
 of_device_id entries

Hi, Angelo:

On Wed, 2023-07-19 at 09:50 +0200, AngeloGioacchino Del Regno wrote:
> Reduce line count by compressing the entries of struct of_device_id;
> while at it, also add the usual /* sentinel */ comment to the last
> entry.
> 
> This commit brings no functional changes.

Reviewed-by: CK Hu <ck.hu@...iatek.com>

> 
> Signed-off-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@...labora.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_dpi.c | 30 ++++++++------------------
> ----
>  1 file changed, 8 insertions(+), 22 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index 244340df7468..ad1be4f9150c 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -1091,28 +1091,14 @@ static void mtk_dpi_remove(struct
> platform_device *pdev)
>  }
>  
>  static const struct of_device_id mtk_dpi_of_ids[] = {
> -	{ .compatible = "mediatek,mt2701-dpi",
> -	  .data = &mt2701_conf,
> -	},
> -	{ .compatible = "mediatek,mt8173-dpi",
> -	  .data = &mt8173_conf,
> -	},
> -	{ .compatible = "mediatek,mt8183-dpi",
> -	  .data = &mt8183_conf,
> -	},
> -	{ .compatible = "mediatek,mt8186-dpi",
> -	  .data = &mt8186_conf,
> -	},
> -	{ .compatible = "mediatek,mt8188-dp-intf",
> -	  .data = &mt8188_dpintf_conf,
> -	},
> -	{ .compatible = "mediatek,mt8192-dpi",
> -	  .data = &mt8192_conf,
> -	},
> -	{ .compatible = "mediatek,mt8195-dp-intf",
> -	  .data = &mt8195_dpintf_conf,
> -	},
> -	{ },
> +	{ .compatible = "mediatek,mt2701-dpi", .data = &mt2701_conf },
> +	{ .compatible = "mediatek,mt8173-dpi", .data = &mt8173_conf },
> +	{ .compatible = "mediatek,mt8183-dpi", .data = &mt8183_conf },
> +	{ .compatible = "mediatek,mt8186-dpi", .data = &mt8186_conf },
> +	{ .compatible = "mediatek,mt8188-dp-intf", .data =
> &mt8188_dpintf_conf },
> +	{ .compatible = "mediatek,mt8192-dpi", .data = &mt8192_conf },
> +	{ .compatible = "mediatek,mt8195-dp-intf", .data =
> &mt8195_dpintf_conf },
> +	{ /* sentinel */ },
>  };
>  MODULE_DEVICE_TABLE(of, mtk_dpi_of_ids);
>