linux-kernel - Re: 'perf test sigtrap' failing on PREEMPT_RT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e368f2c848d77fbc8d259f44e2055fe469c219cf.camel@gmx.de>
Date:   Wed, 26 Jul 2023 08:10:45 +0200
From:   Mike Galbraith <efault@....de>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Marco Elver <elver@...gle.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        linux-rt-users@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Clark Williams <williams@...hat.com>,
        ThomasGleixner <tglx@...utronix.de>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Subject: Re: 'perf test sigtrap' failing on PREEMPT_RT_FULL

On Tue, 2023-07-25 at 17:15 -0300, Arnaldo Carvalho de Melo wrote:
> Hi Marco, Peter,
>
>         I got a report that 'perf test sigtrap' test failed on a
> PREEMPT_RT_FULL kernel, one that had up to:
>
> commit 97ba62b278674293762c3d91f724f1bb922f04e0
> Author: Marco Elver <elver@...gle.com>
> Date:   Thu Apr 8 12:36:01 2021 +0200
>
>     perf: Add support for SIGTRAP on perf events
> ...

> [   52.848925] BUG: scheduling while atomic: perf/6549/0x00000002

Had bf9ad37dc8a not been reverted due to insufficient beauty, you could
trivially make the sigtrap test a happy camper (wart tested in tip-rt).

	-Mike

@@ -1829,6 +1869,9 @@ int send_sig_perf(void __user *addr, u32
 				     TRAP_PERF_FLAG_ASYNC :
 				     0;

+	if (force_sig_delayed(&info, current))
+		return 0;
+
 	return send_sig_info(info.si_signo, &info, current);
 }