[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230726073905.1175826-1-roberto.sassu@huaweicloud.com>
Date: Wed, 26 Jul 2023 09:39:05 +0200
From: Roberto Sassu <roberto.sassu@...weicloud.com>
To: paul@...l-moore.com, jmorris@...ei.org, serge@...lyn.com
Cc: linux-security-module@...r.kernel.org,
linux-kernel@...r.kernel.org,
Roberto Sassu <roberto.sassu@...wei.com>
Subject: [PATCH v2] security: Fix ret values doc for security_inode_init_security()
From: Roberto Sassu <roberto.sassu@...wei.com>
Commit 6bcdfd2cac55 ("security: Allow all LSMs to provide xattrs for
inode_init_security hook") unified the !initxattrs and initxattrs cases. By
doing that, security_inode_init_security() cannot return -EOPNOTSUPP
anymore, as it is always replaced with zero at the end of the function.
Also, mentioning -ENOMEM as the only possible error is not correct. For
example, evm_inode_init_security() could return -ENOKEY.
Fix these issues in the documentation of security_inode_init_security().
Fixes: 6bcdfd2cac55 ("security: Allow all LSMs to provide xattrs for inode_init_security hook")
Signed-off-by: Roberto Sassu <roberto.sassu@...wei.com>
---
security/security.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/security/security.c b/security/security.c
index cfdd0cbbcb9..f86567083e6 100644
--- a/security/security.c
+++ b/security/security.c
@@ -1604,8 +1604,8 @@ EXPORT_SYMBOL(security_dentry_create_files_as);
* a security attribute on this particular inode, then it should return
* -EOPNOTSUPP to skip this processing.
*
- * Return: Returns 0 on success, -EOPNOTSUPP if no security attribute is
- * needed, or -ENOMEM on memory allocation failure.
+ * Return: Returns 0 if the LSM successfully initialized all of the inode
+ * security attributes that are required, negative values otherwise.
*/
int security_inode_init_security(struct inode *inode, struct inode *dir,
const struct qstr *qstr,
--
2.34.1
Powered by blists - more mailing lists