linux-kernel - RE: [PATCH v2 1/2] ASoC: Intel: maxim-common: get codec number from ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY5PR11MB625741E8CCBA25EAA82739579700A@CY5PR11MB6257.namprd11.prod.outlook.com>
Date:   Wed, 26 Jul 2023 08:33:58 +0000
From:   "Lu, Brent" <brent.lu@...el.com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
CC:     "Rojewski, Cezary" <cezary.rojewski@...el.com>,
        Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
        Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Mark Brown <broonie@...nel.org>,
        "Jaroslav Kysela" <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Ajye Huang <ajye_huang@...pal.corp-partner.google.com>,
        "Zhi, Yong" <yong.zhi@...el.com>,
        Terry Cheong <htcheong@...omium.org>,
        "Bhat, Uday M" <uday.m.bhat@...el.com>,
        "Chiang, Mac" <mac.chiang@...el.com>,
        "R, Dharageswari" <dharageswari.r@...el.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        ye xingchen <ye.xingchen@....com.cn>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: RE: [PATCH v2 1/2] ASoC: Intel: maxim-common: get codec number from
 ACPI


> >   const struct snd_soc_dapm_route max_98373_dapm_routes[] = { @@
> > -168,17 +181,6 @@ static struct snd_soc_codec_conf max_98390_codec_conf[]
> = {
> >   		.dlc = COMP_CODEC_CONF(MAX_98390_DEV1_NAME),
> >   		.name_prefix = "Left",
> >   	},
> > -};
> > -
> > -static struct snd_soc_codec_conf max_98390_4spk_codec_conf[] = {
> > -	{
> > -		.dlc = COMP_CODEC_CONF(MAX_98390_DEV0_NAME),
> > -		.name_prefix = "Right",
> > -	},
> > -	{
> > -		.dlc = COMP_CODEC_CONF(MAX_98390_DEV1_NAME),
> > -		.name_prefix = "Left",
> > -	},
> 
> if you remove the codec conf, doesn't this impact the Kcontrols names?
> Does this break existing UCM files?
> 
> It's rather hard to review with just the diff.
> 

I just merge two arrays, max_98373_dapm_routes and max_98390_4spk_codec_conf,
since the first two entries are the same.

Later in max_98390_set_codec_conf() function we will set the num_configs with
number of amplifiers.

void max_98390_set_codec_conf(struct snd_soc_card *card)
{
	unsigned int num_codecs = get_num_codecs(MAX_98390_ACPI_HID);

	card->codec_conf = max_98390_codec_conf;

	switch (num_codecs) {
	case 2:
	case 4:
		card->num_configs = num_codecs;

Regards,
Brent