[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJ9a7VgfFXsnD5mz23aeHBuPj81XErgu1ghNAykWgoYF+aFtMg@mail.gmail.com>
Date: Wed, 26 Jul 2023 10:23:51 +0100
From: Mike Leach <mike.leach@...aro.org>
To: James Clark <james.clark@....com>
Cc: coresight@...ts.linaro.org,
Suzuki K Poulose <suzuki.poulose@....com>,
Leo Yan <leo.yan@...aro.org>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] coresight: Fix all W=1 build warnings
On Tue, 25 Jul 2023 at 15:06, James Clark <james.clark@....com> wrote:
>
> The kernel test robot looks for new warnings in a W=1 build, so fix all
> the existing warnings to make it easier to spot new ones when building
> locally.
>
> The fixes are for undocumented function arguments and an incorrect doc
> style.
>
> Signed-off-by: James Clark <james.clark@....com>
> ---
> drivers/hwtracing/coresight/coresight-cti-core.c | 2 +-
> drivers/hwtracing/coresight/coresight-etm4x-cfg.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-cti-core.c b/drivers/hwtracing/coresight/coresight-cti-core.c
> index 7023ff70cc28..3999d0a2cb60 100644
> --- a/drivers/hwtracing/coresight/coresight-cti-core.c
> +++ b/drivers/hwtracing/coresight/coresight-cti-core.c
> @@ -22,7 +22,7 @@
> #include "coresight-priv.h"
> #include "coresight-cti.h"
>
> -/**
> +/*
> * CTI devices can be associated with a PE, or be connected to CoreSight
> * hardware. We have a list of all CTIs irrespective of CPU bound or
> * otherwise.
> diff --git a/drivers/hwtracing/coresight/coresight-etm4x-cfg.c b/drivers/hwtracing/coresight/coresight-etm4x-cfg.c
> index d2ea903231b2..c302072b293a 100644
> --- a/drivers/hwtracing/coresight/coresight-etm4x-cfg.c
> +++ b/drivers/hwtracing/coresight/coresight-etm4x-cfg.c
> @@ -40,7 +40,7 @@
> * Invalid offsets will result in fail code return and feature load failure.
> *
> * @drvdata: driver data to map into.
> - * @reg: register to map.
> + * @reg_csdev: register to map.
> * @offset: device offset for the register
> */
> static int etm4_cfg_map_reg_offset(struct etmv4_drvdata *drvdata,
> @@ -132,7 +132,7 @@ static int etm4_cfg_map_reg_offset(struct etmv4_drvdata *drvdata,
> * etm4_cfg_load_feature - load a feature into a device instance.
> *
> * @csdev: An ETMv4 CoreSight device.
> - * @feat: The feature to be loaded.
> + * @feat_csdev: The feature to be loaded.
> *
> * The function will load a feature instance into the device, checking that
> * the register definitions are valid for the device.
> --
> 2.34.1
>
Reviewed-by: Mike Leach <mike.leach@...aro.org>
--
Mike Leach
Principal Engineer, ARM Ltd.
Manchester Design Centre. UK
Powered by blists - more mailing lists