linux-kernel - RE: [PATCH next resend 5/5] minmax: Relax check to allow comparison between int and small unsigned constants.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4520ae6dc8b447cbaa77be0cdea79986@AcuMS.aculab.com>
Date:   Wed, 26 Jul 2023 09:29:15 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'kernel test robot' <lkp@...el.com>,
        "'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
        'Andy Shevchenko' <andriy.shevchenko@...ux.intel.com>,
        'Andrew Morton' <akpm@...ux-foundation.org>,
        "'Matthew Wilcox (Oracle)'" <willy@...radead.org>,
        'Christoph Hellwig' <hch@...radead.org>,
        "'Jason A. Donenfeld'" <Jason@...c4.com>
CC:     "oe-kbuild-all@...ts.linux.dev" <oe-kbuild-all@...ts.linux.dev>,
        "Linux Memory Management List" <linux-mm@...ck.org>
Subject: RE: [PATCH next resend 5/5] minmax: Relax check to allow comparison
 between int and small unsigned constants.

From: kernel test robot <lkp@...el.com>
> Sent: 25 July 2023 20:37
> 
...
>    drivers/gpu/drm/drm_modes.c: In function 'drm_mode_parse_command_line_for_connector':
> >> include/linux/minmax.h:23:22: warning: ordered comparison of pointer with integer zero [-Wextra]
>       23 |                 ((x) >= 0 && (x) <= (typeof((x) + 0))(long)__INT_MAX__))
>          |                      ^~
...
>    drivers/gpu/drm/drm_modes.c:2474:29: note: in expansion of macro 'max'
>     2474 |                 extra_ptr = max(bpp_end_ptr, refresh_end_ptr);
>          |                             ^~~

There are a handful of annoying uses of min/max with pointers.
I'll fix this in v2 by adding a cast to the 0.
(I was expecting an error for unsigned types.)

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)