linux-kernel - Re: [EXTERNAL] Re: [PATCH v11 07/10] net: ti: icssg-prueth: Add ICSSG Stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <296b0e98-4012-09f6-84cd-6f87a85f095f@ti.com>
Date:   Wed, 26 Jul 2023 16:06:06 +0530
From:   Md Danish Anwar <a0501179@...com>
To:     Jakub Kicinski <kuba@...nel.org>,
        MD Danish Anwar <danishanwar@...com>
CC:     Randy Dunlap <rdunlap@...radead.org>,
        Roger Quadros <rogerq@...nel.org>,
        Simon Horman <simon.horman@...igine.com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Andrew Lunn <andrew@...n.ch>,
        Richard Cochran <richardcochran@...il.com>,
        Conor Dooley <conor+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>, <nm@...com>, <srk@...com>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <netdev@...r.kernel.org>, <linux-omap@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [EXTERNAL] Re: [PATCH v11 07/10] net: ti: icssg-prueth: Add ICSSG
 Stats

Hi Jakub

On 26/07/23 9:20 am, Jakub Kicinski wrote:
> On Mon, 24 Jul 2023 16:59:31 +0530 MD Danish Anwar wrote:
>> +	/* Rx */
>> +	ICSSG_STATS(rx_packets, true),
>> +	ICSSG_STATS(rx_broadcast_frames, false),
>> +	ICSSG_STATS(rx_multicast_frames, false),
> 
> There is a standard stat for mcast.
> 

Sure. I will add multicast stats via .ndo_get_stats64 instead of ethtool.

>> +	ICSSG_STATS(rx_crc_errors, true),
>> +	ICSSG_STATS(rx_mii_error_frames, false),
>> +	ICSSG_STATS(rx_odd_nibble_frames, false),
>> +	ICSSG_STATS(rx_frame_max_size, false),
>> +	ICSSG_STATS(rx_max_size_error_frames, false),
>> +	ICSSG_STATS(rx_frame_min_size, false),
>> +	ICSSG_STATS(rx_min_size_error_frames, false),
>> +	ICSSG_STATS(rx_over_errors, true),
>> +	ICSSG_STATS(rx_class0_hits, false),
>> +	ICSSG_STATS(rx_class1_hits, false),
>> +	ICSSG_STATS(rx_class2_hits, false),
>> +	ICSSG_STATS(rx_class3_hits, false),
>> +	ICSSG_STATS(rx_class4_hits, false),
>> +	ICSSG_STATS(rx_class5_hits, false),
>> +	ICSSG_STATS(rx_class6_hits, false),
>> +	ICSSG_STATS(rx_class7_hits, false),
>> +	ICSSG_STATS(rx_class8_hits, false),
>> +	ICSSG_STATS(rx_class9_hits, false),
>> +	ICSSG_STATS(rx_class10_hits, false),
>> +	ICSSG_STATS(rx_class11_hits, false),
>> +	ICSSG_STATS(rx_class12_hits, false),
>> +	ICSSG_STATS(rx_class13_hits, false),
>> +	ICSSG_STATS(rx_class14_hits, false),
>> +	ICSSG_STATS(rx_class15_hits, false),
>> +	ICSSG_STATS(rx_smd_frags, false),
>> +	ICSSG_STATS(rx_bucket1_size, false),
>> +	ICSSG_STATS(rx_bucket2_size, false),
>> +	ICSSG_STATS(rx_bucket3_size, false),
>> +	ICSSG_STATS(rx_bucket4_size, false),
> 
> Are the bucket sizes configurable? Can we set the bucket sizes
> to standard RMON ones and use ethtool RMON stats?

The bucket sizes are not configurable. Bucket size is read from hardware and is
fixed. I don't think we can configure bucket size and use ethtool RMON stats.
It's better to dump bucket sizes via ethtool -S.

-- 
Thanks and Regards,
Danish.