linux-kernel - Re: [PATCH V1 1/2] regulator: aw37503: add regulator driver for AWINIC AW37503

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <812a3f8b-7d5d-42f2-aaf2-dcea18f6ffac@sirena.org.uk>
Date:   Wed, 26 Jul 2023 12:41:22 +0100
From:   Mark Brown <broonie@...nel.org>
To:     like@...nic.com
Cc:     lgirdwood@...il.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        liweilei@...nic.com, liangdong@...nic.com, wangweidong.a@...nic.com
Subject: Re: [PATCH V1 1/2] regulator: aw37503: add regulator driver for
 AWINIC AW37503

On Wed, Jul 26, 2023 at 08:16:11AM +0000, like@...nic.com wrote:

> @@ -191,5 +191,6 @@ obj-$(CONFIG_REGULATOR_WM831X) += wm831x-ldo.o
>  obj-$(CONFIG_REGULATOR_WM8350) += wm8350-regulator.o
>  obj-$(CONFIG_REGULATOR_WM8400) += wm8400-regulator.o
>  obj-$(CONFIG_REGULATOR_WM8994) += wm8994-regulator.o
> +obj-$(CONFIG_REGULATOR_AW37503) += aw37503-regulator.o
>  

Please keep the Kconfig and Makefile sorted.

> +static const struct regmap_config aw37503_regmap_config = {
> +	.reg_bits	= 8,
> +	.val_bits	= 8,
> +	.max_register	= AW37503_REG_WPRTEN,
> +	.cache_type	= REGCACHE_NONE,

No need to specify no cache, it's the default.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)