linux-kernel - Re: [PATCH v2] regulator: dt-bindings: dlg,slg51000: Convert to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2df8d695-62aa-329f-f355-d6081d970ec2@linaro.org>
Date:   Wed, 26 Jul 2023 14:18:43 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     Support Opensource <support.opensource@...semi.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Eric Jeong <eric.jeong.opensource@...semi.com>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2] regulator: dt-bindings: dlg,slg51000: Convert to DT
 schema

On 26/07/2023 13:55, Mark Brown wrote:
> On Wed, Jul 26, 2023 at 09:32:17AM +0200, Krzysztof Kozlowski wrote:
>> On 25/07/2023 12:43, Mark Brown wrote:
> 
>>> This is just adding an OS specific note in the description, it's not
>>> actually marking the properties as required.
> 
>> They cannot be required, because it depends whether the regulator is
>> used or not. IOW, they are not required for unused regulators, which is
>> not possible to encode in the schema.
> 
> Oh, you mean if the regulator is in use in the system rather than if
> it's enabled!

Enabled as "always-on" or "boot-on" could be encoded in the schema with
multiple if::then:. But it is not enough, because regulators can be
enabled on demand by drivers. So that's what I meant by "used".


>  I suspect that there's a requirement that either at least
> one of the supplies be provided so that the chip I/O works, or there's
> some other currently undocumented supply that is required for that
> reason.

I can add requirement of at least one supply. I don't think it changes
much, but sure.

> 
> BTW there's also a formatting error:
> 
> +  vin3-supply:
> +    description:
> +      Input supply for ldo3, required if regulatoris enabled
> 
> missing space before is.

I'll fix with above at least one supply required.

Best regards,
Krzysztof