linux-kernel - [PATCH v2] mailbox: Remove error checking for debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20230726123917.7438-1-machel@vivo.com>
Date:   Wed, 26 Jul 2023 20:39:03 +0800
From:   Wang Ming <machel@...o.com>
To:     Jassi Brar <jassisinghbrar@...il.com>, linux-kernel@...r.kernel.org
Cc:     opensource.kernel@...o.com, Wang Ming <machel@...o.com>
Subject: [PATCH v2] mailbox: Remove error checking for debugfs_create_dir()

It is expected that most callers should _ignore_ the errors return by
debugfs_create_dir() in mbox_test_add_debugfs().

Signed-off-by: Wang Ming <machel@...o.com>
---
 drivers/mailbox/mailbox-test.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/mailbox/mailbox-test.c b/drivers/mailbox/mailbox-test.c
index fc6a12a51..54d11c025 100644
--- a/drivers/mailbox/mailbox-test.c
+++ b/drivers/mailbox/mailbox-test.c
@@ -268,10 +268,6 @@ static int mbox_test_add_debugfs(struct platform_device *pdev,
 		return 0;
 
 	tdev->root_debugfs_dir = debugfs_create_dir(dev_name(&pdev->dev), NULL);
-	if (!tdev->root_debugfs_dir) {
-		dev_err(&pdev->dev, "Failed to create Mailbox debugfs\n");
-		return -EINVAL;
-	}
 
 	debugfs_create_file("message", 0600, tdev->root_debugfs_dir,
 			    tdev, &mbox_test_message_ops);
-- 
2.25.1