| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <a2853d8c-00b6-9772-652b-556d503f3cc8@intel.com>
Date: Wed, 26 Jul 2023 15:41:42 +0300
From: Adrian Hunter <adrian.hunter@...el.com>
To: Piyush Malgujar <pmalgujar@...vell.com>, linux-mmc@...r.kernel.org,
linux-kernel@...r.kernel.org, ulf.hansson@...aro.org,
p.zabel@...gutronix.de, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
yamada.masahiro@...ionext.com, devicetree@...r.kernel.org
Cc: jannadurai@...vell.com, cchavva@...vell.com,
Dhananjay Kangude <dkangude@...ence.com>,
Brad Larson <blarson@....com>
Subject: Re: [PATCH v4 2/6] mmc: sdhci-cadence: Restructure the code
On 17/07/23 15:51, Piyush Malgujar wrote:
> From: Dhananjay Kangude <dkangude@...ence.com>
>
> Restructured the code, added controller version specific init for
> SD4 operations with no change to existing functionality.
>
> Signed-off-by: Dhananjay Kangude <dkangude@...ence.com>
> Co-developed-by: Jayanthi Annadurai <jannadurai@...vell.com>
> Signed-off-by: Jayanthi Annadurai <jannadurai@...vell.com>
> Signed-off-by: Piyush Malgujar <pmalgujar@...vell.com>
> ---
> drivers/mmc/host/sdhci-cadence.c | 76 ++++++++++++++++++++++++--------
> 1 file changed, 58 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-cadence.c b/drivers/mmc/host/sdhci-cadence.c
> index 9bb38281bcb244b0be91ef579046c40de7a06e1f..98fe752bcf27a71607623f3cb1c36f1a16d688a4 100644
> --- a/drivers/mmc/host/sdhci-cadence.c
> +++ b/drivers/mmc/host/sdhci-cadence.c
> @@ -60,11 +60,17 @@
> */
> #define SDHCI_CDNS_MAX_TUNING_LOOP 40
>
> +struct sdhci_cdns_priv;
Unnecessary forward declaration.
> +
> struct sdhci_cdns_sd4_phy_param {
> u8 addr;
> u8 data;
> };
>
> +struct sdhci_cdns_sd4_phy {
> + unsigned int nr_phy_params;
> + struct sdhci_cdns_sd4_phy_param phy_params[];
> +};
> struct sdhci_cdns_priv {
> void __iomem *hrs_addr;
> void __iomem *ctl_addr; /* write control */
> @@ -72,8 +78,8 @@ struct sdhci_cdns_priv {
> bool enhanced_strobe;
> void (*priv_writel)(struct sdhci_cdns_priv *priv, u32 val, void __iomem *reg);
> struct reset_control *rst_hw;
> - unsigned int nr_phy_params;
> - struct sdhci_cdns_sd4_phy_param phy_params[];
> + const struct sdhci_cdns_drv_data *cdns_data;
> + void *phy;
> };
>
> struct sdhci_cdns_sd4_phy_cfg {
> @@ -83,6 +89,8 @@ struct sdhci_cdns_sd4_phy_cfg {
>
> struct sdhci_cdns_drv_data {
> int (*init)(struct platform_device *pdev);
> + int (*phy_init)(struct sdhci_cdns_priv *priv);
> + int (*phy_probe)(struct platform_device *pdev, struct sdhci_cdns_priv *priv);
> const struct sdhci_pltfm_data pltfm_data;
> };
>
> @@ -151,9 +159,9 @@ static unsigned int sdhci_cdns_sd4_phy_param_count(struct device_node *np)
> }
>
> static void sdhci_cdns_sd4_phy_param_parse(struct device_node *np,
> - struct sdhci_cdns_priv *priv)
> + struct sdhci_cdns_sd4_phy *phy)
> {
> - struct sdhci_cdns_sd4_phy_param *p = priv->phy_params;
> + struct sdhci_cdns_sd4_phy_param *p = phy->phy_params;
> u32 val;
> int ret, i;
>
> @@ -172,10 +180,11 @@ static void sdhci_cdns_sd4_phy_param_parse(struct device_node *np,
> static int sdhci_cdns_sd4_phy_init(struct sdhci_cdns_priv *priv)
> {
> int ret, i;
> + struct sdhci_cdns_sd4_phy *phy = priv->phy;
>
> - for (i = 0; i < priv->nr_phy_params; i++) {
> - ret = sdhci_cdns_sd4_write_phy_reg(priv, priv->phy_params[i].addr,
> - priv->phy_params[i].data);
> + for (i = 0; i < phy->nr_phy_params; i++) {
> + ret = sdhci_cdns_sd4_write_phy_reg(priv, phy->phy_params[i].addr,
> + phy->phy_params[i].data);
> if (ret)
> return ret;
> }
> @@ -218,6 +227,27 @@ static u32 sdhci_cdns_get_emmc_mode(struct sdhci_cdns_priv *priv)
> return FIELD_GET(SDHCI_CDNS_HRS06_MODE, tmp);
> }
>
> +static int sdhci_cdns_sd4_phy_probe(struct platform_device *pdev,
> + struct sdhci_cdns_priv *priv)
> +{
> + unsigned int nr_phy_params;
> + struct sdhci_cdns_sd4_phy *phy;
> + struct device *dev = &pdev->dev;
> +
> + nr_phy_params = sdhci_cdns_sd4_phy_param_count(dev->of_node);
> + phy = devm_kzalloc(dev, struct_size(phy, phy_params, nr_phy_params),
> + GFP_KERNEL);
> + if (!phy)
> + return -ENOMEM;
> +
> + phy->nr_phy_params = nr_phy_params;
> +
> + sdhci_cdns_sd4_phy_param_parse(dev->of_node, phy);
> + priv->phy = phy;
> +
> + return 0;
> +}
> +
> static int sdhci_cdns_sd4_set_tune_val(struct sdhci_host *host, unsigned int val)
> {
> struct sdhci_cdns_priv *priv = sdhci_cdns_priv(host);
> @@ -420,6 +450,8 @@ static const struct sdhci_ops sdhci_cdns_sd4_ops = {
> };
>
> static const struct sdhci_cdns_drv_data sdhci_cdns_uniphier_drv_data = {
> + .phy_init = sdhci_cdns_sd4_phy_init,
> + .phy_probe = sdhci_cdns_sd4_phy_probe,
> .pltfm_data = {
> .ops = &sdhci_cdns_sd4_ops,
> .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN,
> @@ -428,12 +460,16 @@ static const struct sdhci_cdns_drv_data sdhci_cdns_uniphier_drv_data = {
>
> static const struct sdhci_cdns_drv_data sdhci_elba_drv_data = {
> .init = elba_drv_init,
> + .phy_init = sdhci_cdns_sd4_phy_init,
> + .phy_probe = sdhci_cdns_sd4_phy_probe,
> .pltfm_data = {
> .ops = &sdhci_elba_ops,
> },
> };
>
> static const struct sdhci_cdns_drv_data sdhci_cdns_sd4_drv_data = {
> + .phy_init = sdhci_cdns_sd4_phy_init,
> + .phy_probe = sdhci_cdns_sd4_phy_probe,
> .pltfm_data = {
> .ops = &sdhci_cdns_sd4_ops,
> },
> @@ -482,7 +518,6 @@ static int sdhci_cdns_probe(struct platform_device *pdev)
> struct sdhci_pltfm_host *pltfm_host;
> struct sdhci_cdns_priv *priv;
> struct clk *clk;
> - unsigned int nr_phy_params;
> int ret;
> struct device *dev = &pdev->dev;
> static const u16 version = SDHCI_SPEC_400 << SDHCI_SPEC_VER_SHIFT;
> @@ -496,12 +531,12 @@ static int sdhci_cdns_probe(struct platform_device *pdev)
> return ret;
>
> data = of_device_get_match_data(dev);
> - if (!data)
> - data = &sdhci_cdns_sd4_drv_data;
Why change this?
> + if (!data) {
> + ret = -EINVAL;
> + goto disable_clk;
> + }
>
> - nr_phy_params = sdhci_cdns_sd4_phy_param_count(dev->of_node);
> - host = sdhci_pltfm_init(pdev, &data->pltfm_data,
> - struct_size(priv, phy_params, nr_phy_params));
> + host = sdhci_pltfm_init(pdev, &data->pltfm_data, sizeof(*priv));
> if (IS_ERR(host)) {
> ret = PTR_ERR(host);
> goto disable_clk;
> @@ -511,10 +546,10 @@ static int sdhci_cdns_probe(struct platform_device *pdev)
> pltfm_host->clk = clk;
>
> priv = sdhci_pltfm_priv(pltfm_host);
> - priv->nr_phy_params = nr_phy_params;
> priv->hrs_addr = host->ioaddr;
> priv->enhanced_strobe = false;
> priv->priv_writel = cdns_writel;
> + priv->cdns_data = data;
> host->ioaddr += SDHCI_CDNS_SRS_BASE;
> host->mmc_host_ops.hs400_enhanced_strobe =
> sdhci_cdns_hs400_enhanced_strobe;
> @@ -532,9 +567,11 @@ static int sdhci_cdns_probe(struct platform_device *pdev)
> if (ret)
> goto free;
>
> - sdhci_cdns_sd4_phy_param_parse(dev->of_node, priv);
> + ret = data->phy_probe(pdev, priv);
> + if (ret)
> + goto free;
>
> - ret = sdhci_cdns_sd4_phy_init(priv);
> + ret = priv->cdns_data->phy_init(priv);
data->phy_init() would be consistent with data->phy_probe()
instead of priv->cdns_data->phy_init()
> if (ret)
> goto free;
>
> @@ -574,7 +611,7 @@ static int sdhci_cdns_resume(struct device *dev)
> if (ret)
> return ret;
>
> - ret = sdhci_cdns_sd4_phy_init(priv);
> + ret = priv->cdns_data->phy_init(priv);
> if (ret)
> goto disable_clk;
>
> @@ -604,7 +641,10 @@ static const struct of_device_id sdhci_cdns_match[] = {
> .compatible = "amd,pensando-elba-sd4hc",
> .data = &sdhci_elba_drv_data,
> },
> - { .compatible = "cdns,sd4hc" },
> + {
> + .compatible = "cdns,sd4hc",
> + .data = &sdhci_cdns_sd4_drv_data,
Why change this?
> + },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, sdhci_cdns_match);
Powered by blists - more mailing lists