[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230726134140.7180-3-quic_nitirawa@quicinc.com>
Date: Wed, 26 Jul 2023 19:11:40 +0530
From: Nitin Rawat <quic_nitirawa@...cinc.com>
To: powen.kao@...iatek.com, bvanassche@....org,
alim.akhtar@...sung.com, adrian.hunter@...el.com,
jejb@...ux.ibm.com, stanley.chu@...iatek.com,
asutoshd@...eaurora.org, quic_cang@...cinc.com, mani@...nel.org,
martin.petersen@...cle.com, beanhuo@...ron.com,
ebiggers@...gle.com, agross@...nel.org, Arthur.Simchaev@....com,
konrad.dybcio@...aro.org
Cc: quic_ziqichen@...cinc.com, quic_nguyenb@...cinc.com,
quic_narepall@...cinc.com, linux-scsi@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
Nitin Rawat <quic_nitirawa@...cinc.com>,
Manish Pandey <quic_mapa@...cinc.com>
Subject: [PATCH V2 2/2] scsi: ufs: ufs-qcom: check host controller state
Commit <52a518019ca1> (Fix missing clk change notification) added UFS
clock scaling notification to ufshcd_host_reset_and_restore. This
invokes hibern8 enter and exit on qualcomm platform which fails because
controller is in reset state.
Fix this by checking the Host controller state before sending
hibern8 command.
__ufshcd_wl_resume()
ufshcd_reset_and_restore()
ufshcd_host_reset_and_restore()
ufshcd_scale_clks()
ufshcd_vops_clk_scale_notify()
ufs_qcom_clk_scale_notify()
ufshcd_uic_hibern8_enter()
Fixes: 52a518019ca1 ("scsi: ufs: core: Fix missing clk change notification on host reset")
Co-developed-by: Manish Pandey <quic_mapa@...cinc.com>
Signed-off-by: Manish Pandey <quic_mapa@...cinc.com>
Signed-off-by: Nitin Rawat <quic_nitirawa@...cinc.com>
---
drivers/ufs/host/ufs-qcom.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index 8d6fd4c3324f..95412e98a598 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -1254,6 +1254,10 @@ static int ufs_qcom_clk_scale_notify(struct ufs_hba *hba,
struct ufs_pa_layer_attr *dev_req_params = &host->dev_req_params;
int err = 0;
+ /* check the host controller state before sending hibern8 cmd */
+ if (!ufshcd_is_hba_active(hba))
+ return 0;
+
if (status == PRE_CHANGE) {
err = ufshcd_uic_hibern8_enter(hba);
if (err)
--
2.17.1
Powered by blists - more mailing lists