linux-kernel - Re: [PATCH net-next v2] page_pool: split types and declarations from page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <39dbeb07-0328-6126-4f38-c1c5dd7e0dee@intel.com>
Date:   Thu, 27 Jul 2023 15:58:11 +0200
From:   Alexander Lobakin <aleksander.lobakin@...el.com>
To:     Yunsheng Lin <linyunsheng@...wei.com>
CC:     Jakub Kicinski <kuba@...nel.org>,
        Ilias Apalodimas <ilias.apalodimas@...aro.org>,
        <davem@...emloft.net>, <pabeni@...hat.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Wei Fang <wei.fang@....com>,
        Shenwei Wang <shenwei.wang@....com>,
        Clark Wang <xiaoning.wang@....com>,
        NXP Linux Team <linux-imx@....com>,
        Sunil Goutham <sgoutham@...vell.com>,
        Geetha sowjanya <gakula@...vell.com>,
        Subbaraya Sundeep <sbhatta@...vell.com>,
        hariprasad <hkelam@...vell.com>,
        Saeed Mahameed <saeedm@...dia.com>,
        Leon Romanovsky <leon@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        "John Fastabend" <john.fastabend@...il.com>,
        Felix Fietkau <nbd@....name>,
        "Lorenzo Bianconi" <lorenzo@...nel.org>,
        Ryder Lee <ryder.lee@...iatek.com>,
        "Shayne Chen" <shayne.chen@...iatek.com>,
        Sean Wang <sean.wang@...iatek.com>,
        "Kalle Valo" <kvalo@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        <linux-rdma@...r.kernel.org>, <bpf@...r.kernel.org>,
        <linux-wireless@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH net-next v2] page_pool: split types and declarations from
 page_pool.h

From: Yunsheng Lin <linyunsheng@...wei.com>
Date: Thu, 27 Jul 2023 19:47:23 +0800

> On 2023/7/26 23:47, Jakub Kicinski wrote:
>> On Wed, 26 Jul 2023 12:48:05 +0200 Alexander Lobakin wrote:
>>>> I prefer the more systematic approach of creating a separate types.h
>>>> file, so I don't have to keep chasing people or cleaning up the include
>>>> hell myself. I think it should be adopted more widely going forward,
>>>> it's not just about the page pool.  
>>>
>>> I have this patch reworked to introduce
>>> include/net/page_pool/{types,helpers}.h in my tree, maybe someone could
>>> take a quick look[0] and say if this works while I'm preparing the next
>>> version for sending? Not the most MLish way, I know :s
>>>
>>> [0]
>>> https://github.com/alobakin/linux/commit/19741ee072c32eb1d30033cd4fcb236d1c00bfbf
>>
>> LGTM!
> 
> Hi, Alexander
> It seems you have taken it and adjust it accordingly, do you mind sending
> the next version along with your patchset, so that there is less patch
> conflict for both of us:)

Sure, I'm planning to do that, just had some work burden. I'm sending
the next rev today if everything goes fine.

> 
>>
>> .
>>

Thanks,
Olek