linux-kernel - Re: [PATCH v9 2/6] iommufd: Allow passing in iopt_access_list_id to iopt_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZMKAfw02spcSIrcG@nvidia.com>
Date:   Thu, 27 Jul 2023 11:34:39 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Nicolin Chen <nicolinc@...dia.com>
Cc:     kevin.tian@...el.com, yi.l.liu@...el.com, joro@...tes.org,
        will@...nel.org, robin.murphy@....com, alex.williamson@...hat.com,
        shuah@...nel.org, linux-kernel@...r.kernel.org,
        iommu@...ts.linux.dev, kvm@...r.kernel.org,
        linux-kselftest@...r.kernel.org, mjrosato@...ux.ibm.com,
        farman@...ux.ibm.com
Subject: Re: [PATCH v9 2/6] iommufd: Allow passing in iopt_access_list_id to
 iopt_remove_access()

On Thu, Jul 27, 2023 at 12:23:07AM -0700, Nicolin Chen wrote:
> This is a preparatory change for ioas replacement support for access.
> The replacement routine does an iopt_add_access() at a new IOAS first
> and then iopt_remove_access() at the old IOAS upon the success of the
> first call. However, the first call overrides the iopt_access_list_id
> in the access struct, resulting in that id un-erased in the xarray.
> 
> Add an iopt_access_list_id in iopt_remove_access, so the replacement
> routine can save the id before it gets overwritten, and pass the id
> in iopt_remove_access() for a proper cleanup.
> 
> The existing callers should just pass in access->iopt_access_list_id.
> 
> Signed-off-by: Nicolin Chen <nicolinc@...dia.com>
> ---
>  drivers/iommu/iommufd/device.c          | 6 ++++--
>  drivers/iommu/iommufd/io_pagetable.c    | 6 +++---
>  drivers/iommu/iommufd/iommufd_private.h | 3 ++-
>  3 files changed, 9 insertions(+), 6 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@...dia.com>

Jason