linux-kernel - Re: [PATCH v1 1/1] serial: core: Replace strncmp()+strlen() with plain strcmp()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 27 Jul 2023 17:36:01 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Tony Lindgren <tony@...mide.com>,
        Dan Carpenter <dan.carpenter@...aro.org>,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Cc:     Jiri Slaby <jirislaby@...nel.org>
Subject: Re: [PATCH v1 1/1] serial: core: Replace strncmp()+strlen() with
 plain strcmp()

On Thu, Jul 27, 2023 at 02:59:37PM +0300, Andy Shevchenko wrote:
> On Thu, Jul 27, 2023 at 12:05:07PM +0300, Andy Shevchenko wrote:
> > There is no sense to call strlen() ahead of strncmp().
> > The same effect can be achieved by calling strcmp() directly.
> > Replace strncmp()+strlen() with plain strcmp().
> 
> It seems I will have more against serial core, perhaps it makes sense to unite
> them in a single series.

Actually this change is simply wrong. Sorry for the noise.

-- 
With Best Regards,
Andy Shevchenko