[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <87o7jxs6ei.fsf@minerva.mail-host-address-is-not-set>
Date: Thu, 27 Jul 2023 17:47:33 +0200
From: Javier Martinez Canillas <javierm@...hat.com>
To: Thomas Zimmermann <tzimmermann@...e.de>,
linux-kernel@...r.kernel.org
Cc: Arnd Bergmann <arnd@...db.de>, Maxime Ripard <mripard@...nel.org>,
dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/ssd130x: Use shadow-buffer helpers when managing
plane's state
Javier Martinez Canillas <javierm@...hat.com> writes:
> Thomas Zimmermann <tzimmermann@...e.de> writes:
>
> Hello Thomas,
>
>> Hi Javier
>>
>> Am 27.07.23 um 16:04 schrieb Javier Martinez Canillas:
>>> The commit 45b58669e532 ("drm/ssd130x: Allocate buffer in the plane's
>>> .atomic_check() callback") moved the buffers allocation to be done in
>>> the primary plane's .atomic_check() callback.
>>>
>>> But it missed that since the driver uses a shadow-buffered plane, the
>>> __drm_gem_{reset,duplicate,destroy}_shadow_plane() helper functions
>>> must be used in the struct drm_plane_funcs handlers.
>>>
>>> This was missed because the mentioned commit did not remove the macro
>>> DRM_GEM_SHADOW_PLANE_FUNCS, which leads to the custom plane's atomic
>>> state management handlers to not be used.
>>>
>>> Fixes: 45b58669e532 ("drm/ssd130x: Allocate buffer in the plane's .atomic_check() callback")
>>> Reported-by: Arnd Bergmann <arnd@...db.de>
>>
>> Reported-by needs to be followed by
>>
>> Closes: <url>
>>
>> where <url> would point to Arnd's bug report on dri-devel.
>>
>
> Ah, I thought checkpatch complaining about it but since we already add a
> Link: with dim, didn't know what to add there. Makes sense to add Arnd's
> report indeed.
>
> I can include it when applying instead of posting a v2 if you don't mind.
>
Pushed to drm-misc (drm-misc-next), adding:
Closes: https://lore.kernel.org/dri-devel/20230727122412.2464210-1-arnd@kernel.org
Thanks!
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Powered by blists - more mailing lists