linux-kernel - Re: [PATCH] mtd: fix use-after-free in mtd release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230727183611.37d01f51@xps-13>
Date:   Thu, 27 Jul 2023 18:36:11 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Alexander Usyskin <alexander.usyskin@...el.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Tomas Winkler <tomas.winkler@...el.com>,
        Vitaly Lubart <vitaly.lubart@...el.com>,
        Zhang Xiaoxu <zhangxiaoxu5@...wei.com>
Subject: Re: [PATCH] mtd: fix use-after-free in mtd release

Hi Andy,

andriy.shevchenko@...ux.intel.com wrote on Thu, 27 Jul 2023 18:58:29
+0300:

> On Thu, Jul 27, 2023 at 05:20:13PM +0200, Miquel Raynal wrote:
> > andriy.shevchenko@...ux.intel.com wrote on Thu, 27 Jul 2023 18:12:04
> > +0300:  
> > > On Thu, Jul 27, 2023 at 05:57:58PM +0300, Alexander Usyskin wrote:  
> 
> ...
> 
> > > > Fixes: 19bfa9ebebb5 ("mtd: use refcount to prevent corruption")  
> > > 
> > > Closes: ?  
> > 
> > Did I miss a recent update on the use of Fixes?  
> 
> They are orthogonal to each other. Actually Closes goes closer with
> Reported-by.
> 
> I believe both of them needs to be added (by I might miss something).
> 
> > I thought Closes was
> > supposed to point at a bug report while Fixes would point to the faulty
> > commit.  
> 
> Correct.
> 
> > Right now I feel like Fixes is the right tag,  
> 
> Nobody objects that (see above).
> 
> > but if you have a source explaining why we should not longer do it like
> > I am used to, I would appreciate a link.  
> 
> Since you know about Closes already, I think there is nothing to add.

Ah sorry I misunderstood your first e-mail. I thought you were
suggesting to replace Fixes by Closes. Sorry for the misunderstanding :)

Thanks,
Miquèl