lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230727163103.GB20050@brightrain.aerifal.cx>
Date:   Thu, 27 Jul 2023 12:31:04 -0400
From:   "dalias@...c.org" <dalias@...c.org>
To:     David Laight <David.Laight@...LAB.COM>
Cc:     'Aleksa Sarai' <cyphar@...har.com>,
        Alexey Gladkov <legion@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        "linux-api@...r.kernel.org" <linux-api@...r.kernel.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
        "James.Bottomley@...senpartnership.com" 
        <James.Bottomley@...senpartnership.com>,
        "acme@...nel.org" <acme@...nel.org>,
        "alexander.shishkin@...ux.intel.com" 
        <alexander.shishkin@...ux.intel.com>,
        "axboe@...nel.dk" <axboe@...nel.dk>,
        "benh@...nel.crashing.org" <benh@...nel.crashing.org>,
        "borntraeger@...ibm.com" <borntraeger@...ibm.com>,
        "bp@...en8.de" <bp@...en8.de>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "christian@...uner.io" <christian@...uner.io>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "deepa.kernel@...il.com" <deepa.kernel@...il.com>,
        "deller@....de" <deller@....de>,
        "dhowells@...hat.com" <dhowells@...hat.com>,
        "fenghua.yu@...el.com" <fenghua.yu@...el.com>,
        "fweimer@...hat.com" <fweimer@...hat.com>,
        "geert@...ux-m68k.org" <geert@...ux-m68k.org>,
        "glebfm@...linux.org" <glebfm@...linux.org>,
        "gor@...ux.ibm.com" <gor@...ux.ibm.com>,
        "hare@...e.com" <hare@...e.com>, "hpa@...or.com" <hpa@...or.com>,
        "ink@...assic.park.msu.ru" <ink@...assic.park.msu.ru>,
        "jhogan@...nel.org" <jhogan@...nel.org>,
        "kim.phillips@....com" <kim.phillips@....com>,
        "ldv@...linux.org" <ldv@...linux.org>,
        "linux-alpha@...r.kernel.org" <linux-alpha@...r.kernel.org>,
        "linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
        "linux-ia64@...r.kernel.org" <linux-ia64@...r.kernel.org>,
        "linux-m68k@...ts.linux-m68k.org" <linux-m68k@...ts.linux-m68k.org>,
        "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
        "linux-parisc@...r.kernel.org" <linux-parisc@...r.kernel.org>,
        "linux-s390@...r.kernel.org" <linux-s390@...r.kernel.org>,
        "linux-sh@...r.kernel.org" <linux-sh@...r.kernel.org>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "luto@...nel.org" <luto@...nel.org>,
        "mattst88@...il.com" <mattst88@...il.com>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "monstr@...str.eu" <monstr@...str.eu>,
        "mpe@...erman.id.au" <mpe@...erman.id.au>,
        "namhyung@...nel.org" <namhyung@...nel.org>,
        "paulus@...ba.org" <paulus@...ba.org>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "ralf@...ux-mips.org" <ralf@...ux-mips.org>,
        "sparclinux@...r.kernel.org" <sparclinux@...r.kernel.org>,
        "stefan@...er.ch" <stefan@...er.ch>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "tony.luck@...el.com" <tony.luck@...el.com>,
        "tycho@...ho.ws" <tycho@...ho.ws>,
        "will@...nel.org" <will@...nel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "ysato@...rs.sourceforge.jp" <ysato@...rs.sourceforge.jp>,
        Palmer Dabbelt <palmer@...ive.com>
Subject: Re: [PATCH v4 2/5] fs: Add fchmodat2()

On Thu, Jul 27, 2023 at 09:01:06AM +0000, David Laight wrote:
> From: Aleksa Sarai
> > Sent: 25 July 2023 17:36
> ....
> > We almost certainly want to support AT_EMPTY_PATH at the same time.
> > Otherwise userspace will still need to go through /proc when trying to
> > chmod a file handle they have.
> 
> That can't be allowed.
> 
> Just because a process has a file open and write access to
> the directory that contains it doesn't mean they are allowed
> to change the file permissions.
> 
> They also need directory search access from a directory
> they have open through to the containing directory.

Am I missing something? How is this different from fchmod?

Rich

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ