linux-kernel - Re: [PATCH v2 2/2] ARM: tegra: transformers: add connector node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Jul 2023 19:52:56 +0300
From:   Svyatoslav Ryhel <clamor95@...il.com>
To:     Thierry Reding <thierry.reding@...il.com>
CC:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Mikko Perttunen <mperttunen@...dia.com>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Maxim Schwalm <maxim.schwalm@...il.com>,
        Dmitry Osipenko <digetx@...il.com>, devicetree@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v2 2/2] ARM: tegra: transformers: add connector node



27 липня 2023 р. 19:50:35 GMT+03:00, Thierry Reding <thierry.reding@...il.com> написав(-ла):
>On Thu, Jul 27, 2023 at 07:26:28PM +0300, Svyatoslav Ryhel wrote:
>> 
>> 
>> 27 липня 2023 р. 18:11:15 GMT+03:00, Thierry Reding <thierry.reding@...il.com> написав(-ла):
>> >On Sun, Jun 18, 2023 at 11:50:46AM +0300, Svyatoslav Ryhel wrote:
>> >> All ASUS Transformers have micro-HDMI connector directly available.
>> >> After Tegra HDMI got bridge/connector support, we should use connector
>> >> framework for proper HW description.
>> >> 
>> >> Tested-by: Andreas Westman Dorcsak <hedmoo@...oo.com> # ASUS TF T30
>> >> Tested-by: Robert Eckelmann <longnoserob@...il.com> # ASUS TF101 T20
>> >> Tested-by: Svyatoslav Ryhel <clamor95@...il.com> # ASUS TF201 T30
>> >> Signed-off-by: Svyatoslav Ryhel <clamor95@...il.com>
>> >> ---
>> >>  arch/arm/boot/dts/tegra20-asus-tf101.dts      | 22 ++++++++++++++++---
>> >>  .../dts/tegra30-asus-transformer-common.dtsi  | 21 ++++++++++++++++--
>> >>  2 files changed, 38 insertions(+), 5 deletions(-)
>> >> 
>> >> diff --git a/arch/arm/boot/dts/tegra20-asus-tf101.dts b/arch/arm/boot/dts/tegra20-asus-tf101.dts
>> >> index c2a9c3fb5b33..97350f566539 100644
>> >> --- a/arch/arm/boot/dts/tegra20-asus-tf101.dts
>> >> +++ b/arch/arm/boot/dts/tegra20-asus-tf101.dts
>> >> @@ -82,9 +82,11 @@ hdmi@...80000 {
>> >>  			pll-supply = <&hdmi_pll_reg>;
>> >>  			hdmi-supply = <&vdd_hdmi_en>;
>> >>  
>> >> -			nvidia,ddc-i2c-bus = <&hdmi_ddc>;
>> >> -			nvidia,hpd-gpio = <&gpio TEGRA_GPIO(N, 7)
>> >> -				GPIO_ACTIVE_HIGH>;
>> >> +			port@0 {
>> >> +				hdmi_out: endpoint {
>> >> +					remote-endpoint = <&connector_in>;
>> >> +				};
>> >> +			};
>> >
>> >Does this need a bindings change? nvidia,tegra20-hdmi currently doesn't
>> >support OF graphs, so this would probably fail to validate if we merge
>> >it without a corresponding DT bindings update.
>> 
>> drm/tegra patch is backwards compatible and connector node is optional.
>
>We still need to document the connector node, otherwise the DT
>validation will complain about port@0 being used here, won't it?

Honestly? I have no idea, linux dt yamls are my nightmare and a reason why most of my patches still are hanging in the void of mailing lists.

>Thierry