linux-kernel - Re: [PATCH next] net: ethernet: slicoss: remove redundant increment of pointer data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <64213517-099b-e5a7-6cf3-2f78fa59ee99@gmail.com>
Date:   Thu, 27 Jul 2023 18:15:19 +0100
From:   "Colin King (gmail)" <colin.i.king@...il.com>
To:     Markus Elfring <Markus.Elfring@....de>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Lino Sanfilippo <LinoSanfilippo@....de>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH next] net: ethernet: slicoss: remove redundant increment
 of pointer data

On 26/07/2023 21:05, Markus Elfring wrote:
>> The pointer data is being incremented but this change to the pointer
>> is not used afterwards. The increment is redundant and can be removed.
> 
> Are imperative change descriptions still preferred?

Hrm, I've used this style of commit message for a few thousand commits, 
I hope it's still fine.

> 
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc3#n94
> 
> Regards,
> Markus