[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230727.174206-real.town.kosher.menu-lN1F8uSeAtB@cyphar.com>
Date: Fri, 28 Jul 2023 03:42:22 +1000
From: Aleksa Sarai <cyphar@...har.com>
To: Christian Brauner <brauner@...nel.org>
Cc: Alexey Gladkov <legion@...nel.org>,
LKML <linux-kernel@...r.kernel.org>,
Arnd Bergmann <arnd@...db.de>, linux-api@...r.kernel.org,
linux-fsdevel@...r.kernel.org, viro@...iv.linux.org.uk,
Palmer Dabbelt <palmer@...ive.com>,
James.Bottomley@...senpartnership.com, acme@...nel.org,
alexander.shishkin@...ux.intel.com, axboe@...nel.dk,
benh@...nel.crashing.org, borntraeger@...ibm.com, bp@...en8.de,
catalin.marinas@....com, christian@...uner.io, dalias@...c.org,
davem@...emloft.net, deepa.kernel@...il.com, deller@....de,
dhowells@...hat.com, fenghua.yu@...el.com, fweimer@...hat.com,
geert@...ux-m68k.org, glebfm@...linux.org, gor@...ux.ibm.com,
hare@...e.com, hpa@...or.com, ink@...assic.park.msu.ru,
jhogan@...nel.org, kim.phillips@....com, ldv@...linux.org,
linux-alpha@...r.kernel.org, linux-arch@...r.kernel.org,
linux-ia64@...r.kernel.org, linux-m68k@...ts.linux-m68k.org,
linux-mips@...r.kernel.org, linux-parisc@...r.kernel.org,
linux-s390@...r.kernel.org, linux-sh@...r.kernel.org,
linux@...linux.org.uk, linuxppc-dev@...ts.ozlabs.org,
luto@...nel.org, mattst88@...il.com, mingo@...hat.com,
monstr@...str.eu, mpe@...erman.id.au, namhyung@...nel.org,
paulus@...ba.org, peterz@...radead.org, ralf@...ux-mips.org,
sparclinux@...r.kernel.org, stefan@...er.ch, tglx@...utronix.de,
tony.luck@...el.com, tycho@...ho.ws, will@...nel.org,
x86@...nel.org, ysato@...rs.sourceforge.jp
Subject: Re: [PATCH v4 3/5] arch: Register fchmodat2, usually as syscall 452
On 2023-07-27, Christian Brauner <brauner@...nel.org> wrote:
> On Wed, Jul 26, 2023 at 02:43:41AM +1000, Aleksa Sarai wrote:
> > On 2023-07-11, Alexey Gladkov <legion@...nel.org> wrote:
> > > From: Palmer Dabbelt <palmer@...ive.com>
> > >
> > > This registers the new fchmodat2 syscall in most places as nuber 452,
> > > with alpha being the exception where it's 562. I found all these sites
> > > by grepping for fspick, which I assume has found me everything.
> >
> > Shouldn't this patch be squashed with the patch that adds the syscall?
> > At least, that's how I've usually seen it done...
>
> Depends. Iirc, someone said they'd prefer for doing it in one patch
> in some circumstances on some system call we added years ago. But otoh,
> having the syscall wiring done separately makes it easy for arch
> maintainers to ack only the wiring up part. Both ways are valid imho.
> (cachestat() did it for x86 and then all the others separately. So
> really it seems a bit all over the place depending on the scenario.)
Fair enough!
--
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists