linux-kernel - Re: [PATCH] fuse: enable larger read buffers for readdir.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21fff874-d4ed-1781-32a6-06f154a4bc99@fastmail.fm>
Date:   Thu, 27 Jul 2023 21:43:01 +0200
From:   Bernd Schubert <bernd.schubert@...tmail.fm>
To:     Miklos Szeredi <miklos@...redi.hu>, Jaco Kroon <jaco@....co.za>
Cc:     Antonio SJ Musumeci <trapexit@...wn.link>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fuse: enable larger read buffers for readdir.



On 7/27/23 21:21, Miklos Szeredi wrote:
> On Wed, 26 Jul 2023 at 20:40, Jaco Kroon <jaco@....co.za> wrote:
> 
>> Will look into FUSE_INIT.  The FUSE_INIT as I understand from what I've
>> read has some expansion constraints or the structure is somehow
>> negotiated.  Older clients in other words that's not aware of the option
>> will follow some default.  For backwards compatibility that default
>> should probably be 1 page.  For performance reasons it makes sense that
>> this limit be larger.
> 
> Yes, might need this for backward compatibility.  But perhaps a
> feature flag is enough and the readdir buf can be limited to
> fc->max_read.

fc->max_read is set by default to ~0 and only set to something else when 
the max_read mount option is given? So typically that is a large value 
(UINT_MAX)?


Thanks,
Bernd