linux-kernel - Re: [EXTERNAL] Re: [EXTERNAL] Re: [PATCH v11 07/10] net: ti: icssg-prueth: Add ICSSG Stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17b67407-0507-8978-0d6b-04578ca6b812@ti.com>
Date:   Thu, 27 Jul 2023 10:21:57 +0530
From:   "Anwar, Md Danish" <a0501179@...com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     MD Danish Anwar <danishanwar@...com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Roger Quadros <rogerq@...nel.org>,
        Simon Horman <simon.horman@...igine.com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Andrew Lunn <andrew@...n.ch>,
        Richard Cochran <richardcochran@...il.com>,
        Conor Dooley <conor+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>, <nm@...com>, <srk@...com>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <netdev@...r.kernel.org>, <linux-omap@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [EXTERNAL] Re: [EXTERNAL] Re: [PATCH v11 07/10] net: ti:
 icssg-prueth: Add ICSSG Stats

On 7/26/2023 9:09 PM, Jakub Kicinski wrote:
> On Wed, 26 Jul 2023 16:06:06 +0530 Md Danish Anwar wrote:
>>> Are the bucket sizes configurable? Can we set the bucket sizes
>>> to standard RMON ones and use ethtool RMON stats?
>>
>> The bucket sizes are not configurable. Bucket size is read from hardware and is
>> fixed. I don't think we can configure bucket size and use ethtool RMON stats.
>> It's better to dump bucket sizes via ethtool -S.
> 
> The buckets in the ethtool API are up to the device to define.
> Driver returns bucket ranges via struct ethtool_rmon_hist_range
> from struct ethtool_ops::get_rmon_stats.

Sure Jakub I will try to implement this using ethtool_ops::get_rmon_stats.

-- 
Thanks and Regards,
Md Danish Anwar