linux-kernel - Re: [PATCH 04/30] usb: ohci-at91: Remove redundant msg at probe time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6bea2a28-7d99-d459-d18a-182709ba027b@tuxon.dev>
Date:   Thu, 27 Jul 2023 08:35:59 +0300
From:   claudiu beznea <claudiu.beznea@...on.dev>
To:     Yangtao Li <frank.li@...o.com>,
        Alan Stern <stern@...land.harvard.edu>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>
Cc:     linux-usb@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/30] usb: ohci-at91: Remove redundant msg at probe time



On 26.07.2023 14:37, Yangtao Li wrote:
> platform_get_irq() directly prints error information.
> 
> Signed-off-by: Yangtao Li <frank.li@...o.com>

Reviewed-by: Claudiu Beznea <claudiu.beznea@...on.dev>

> ---
>   drivers/usb/host/ohci-at91.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c
> index f957d008f360..439d8a16d7c5 100644
> --- a/drivers/usb/host/ohci-at91.c
> +++ b/drivers/usb/host/ohci-at91.c
> @@ -190,10 +190,8 @@ static int usb_hcd_at91_probe(const struct hc_driver *driver,
>   	int irq;
>   
>   	irq = platform_get_irq(pdev, 0);
> -	if (irq < 0) {
> -		dev_dbg(dev, "hcd probe: missing irq resource\n");
> +	if (irq < 0)
>   		return irq;
> -	}
>   
>   	hcd = usb_create_hcd(driver, dev, "at91");
>   	if (!hcd)