linux-kernel - RE: [PATCH v2] dt-bindings: net: xilinx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BN8PR12MB285265974F825587DFAD1748F701A@BN8PR12MB2852.namprd12.prod.outlook.com>
Date:   Thu, 27 Jul 2023 07:51:09 +0000
From:   "Somisetty, Pranavi" <pranavi.somisetty@....com>
To:     Rob Herring <robh@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "Simek, Michal" <michal.simek@....com>,
        "Katakam, Harini" <harini.katakam@....com>,
        "git (AMD-Xilinx)" <git@....com>,
        "Pandey, Radhey Shyam" <radhey.shyam.pandey@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v2] dt-bindings: net: xilinx_gmii2rgmii: Convert to json
 schema



> -----Original Message-----
> From: Somisetty, Pranavi <pranavi.somisetty@....com>
> Sent: Monday, July 24, 2023 6:47 PM
> To: Rob Herring <robh@...nel.org>
> Cc: davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
> krzysztof.kozlowski+dt@...aro.org; conor+dt@...nel.org; Simek, Michal
> <michal.simek@....com>; Katakam, Harini <harini.katakam@....com>;
> git (AMD-Xilinx) <git@....com>; Pandey, Radhey Shyam
> <radhey.shyam.pandey@....com>; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; devicetree@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org
> Subject: RE: [PATCH v2] dt-bindings: net: xilinx_gmii2rgmii: Convert to json
> schema
> 
> 
> 
> > -----Original Message-----
> > From: Rob Herring <robh@...nel.org>
> > Sent: Wednesday, July 19, 2023 11:52 PM
> > To: Somisetty, Pranavi <pranavi.somisetty@....com>
> > Cc: davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
> > krzysztof.kozlowski+dt@...aro.org; conor+dt@...nel.org; Simek, Michal
> > <michal.simek@....com>; Katakam, Harini <harini.katakam@....com>;
> git
> > (AMD-Xilinx) <git@....com>; Pandey, Radhey Shyam
> > <radhey.shyam.pandey@....com>; netdev@...r.kernel.org; linux-
> > kernel@...r.kernel.org; devicetree@...r.kernel.org; linux-arm-
> > kernel@...ts.infradead.org
> > Subject: Re: [PATCH v2] dt-bindings: net: xilinx_gmii2rgmii: Convert
> > to json schema
> >
<snip>

> > > +
> > > +  phy-handle:
> > > +    $ref: ethernet-controller.yaml#/properties/phy-handle
> >
> > Don't reference individual properties like this. Instead add a $ref at
> > the top level to just "ethernet-controller.yaml#". Since this is the
> > only property you want from there, put a 'phy-handle: true' here and
> > use additionalProperties instead of unevaluatedProperties below.
> >
> 
> Adding a top level $ref to ethernet-controller, implies, DT for gmii2rgmii,
> follows the schema in ethernet-controller.yaml. This is incorrect since
> gmii2rgmii IP isn't an ethernet controller.
> I'm not sure how to reference ethernet-controller.yaml from this schema.
> Would it be okay to add a description to the phy-handle property instead of
> referencing the description in ethernet-controller.yaml?
> 
> Regards
> Pranavi

Just FYI, when I add a $ref pointing to ethernet-controller.yaml, this is the error I'm seeing: Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.example.dtb: gmiitorgmii@8: $nodename:0: 'gmiitorgmii@8' does not match '^ethernet(@.*)?$'

Regards,
Pranavi
> > > +required:
> > > +  - compatible
> > > +  - reg
> > > +  - phy-handle
> > > +
> > > +unevaluatedProperties: false
> > > +
> > > +examples:
> > > +  - |
> > > +    mdio {
> > > +        #address-cells = <1>;
> > > +        #size-cells = <0>;
> > > +        phy: ethernet-phy@0 {
> > > +            reg = <0>;
> > > +        };
> > > +        gmiitorgmii@8 {
> > > +            compatible = "xlnx,gmii-to-rgmii-1.0";
> > > +            reg = <8>;
> > > +            phy-handle = <&phy>;
> > > +        };
> > > +    };
> > > --
> > > 2.36.1
> > >